Bug 201300 – Make NetworkConnectionToWebProcess keyed by its WebProcess identifier

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

Make NetworkConnectionToWebProcess keyed by their WebProcess identifier

[youenn fablet]

Created attachment 377572 [details]
Patch

[youenn fablet]

Created attachment 377691 [details]
Patch

[youenn fablet]

Created attachment 377695 [details]
Patch

[Alex Christensen]

Comment on attachment 377695 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377695&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:389
> +    return std::make_pair(socketPair.server, IPC::Attachment { socketPair.client });

You could use {} instead of std::make_pair

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:420
> +        completionHandler({ });

WTF::null opt

[youenn fablet]

(In reply to Alex Christensen from comment #4)
> Comment on attachment 377695 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=377695&action=review
> 
> > Source/WebKit/NetworkProcess/NetworkProcess.cpp:389
> > +    return std::make_pair(socketPair.server, IPC::Attachment { socketPair.client });
> 
> You could use {} instead of std::make_pair

The function returns an Optional<std::pair> so we need to return a pair explicitly here.

[youenn fablet]

Created attachment 377840 [details]
Fix Wincairo

[WebKit Commit Bot]

Comment on attachment 377840 [details]
Fix Wincairo

Clearing flags on attachment: 377840

Committed r249379: <https://trac.webkit.org/changeset/249379>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54945251>