Bug 201299 – Move MessageRegistry to NetworkProcess

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

This will remove unnecessary hops for service worker messages.

[youenn fablet]

Created attachment 377571 [details]
Patch

[youenn fablet]

Created attachment 377850 [details]
Patch

[youenn fablet]

Created attachment 377853 [details]
Patch

[youenn fablet]

Only downside is that, currently, on network process crash, the registry information is gone and would need to be rebuilt on network process crash recovery.

[youenn fablet]

Comment on attachment 377853 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377853&action=review

> Source/WebKit/UIProcess/API/APIContextMenuElementInfo.h:35
> +#include <wtf/RetainPtr.h>

here and below: unified build fix apparently.

[Alex Christensen]

Comment on attachment 377853 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377853&action=review

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:962
> +void NetworkConnectionToWebProcess::checkRemotePortForActivity(const WebCore::MessagePortIdentifier port, CompletionHandler<void(bool)>&& callback)

It would make things a bit cleaner to make this CompletionHandler<void(HasActivity)>

> Source/WebKit/NetworkProcess/NetworkMessagePortChannelProvider.cpp:68
> +    // Should never be called in the UI process provider.
> +    ASSERT_NOT_REACHED();

Can we remove all these?
Could we at least write code that calls the CompletionHandlers?

[youenn fablet]

(In reply to Alex Christensen from comment #6)
> Comment on attachment 377853 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=377853&action=review
> 
> > Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:962
> > +void NetworkConnectionToWebProcess::checkRemotePortForActivity(const WebCore::MessagePortIdentifier port, CompletionHandler<void(bool)>&& callback)
> 
> It would make things a bit cleaner to make this
> CompletionHandler<void(HasActivity)>

OK

> > Source/WebKit/NetworkProcess/NetworkMessagePortChannelProvider.cpp:68
> > +    // Should never be called in the UI process provider.
> > +    ASSERT_NOT_REACHED();
> 
> Can we remove all these?
> Could we at least write code that calls the CompletionHandlers?

Patch at bug 201400 will fix this.

[youenn fablet]

Created attachment 377969 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 377969 [details]
Patch for landing

Clearing flags on attachment: 377969

Committed r249479: <https://trac.webkit.org/changeset/249479>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55015929>

[Alex Christensen]

Comment on attachment 377969 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=377969&action=review

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:945
> +    auto callback = m_messageBatchDeliveryCompletionHandlers.take(messageBatchIdentifier);
> +    ASSERT(callback);
> +    callback();

This caused https://bugs.webkit.org/show_bug.cgi?id=204460