Bug 201145 – Resync web-platform-tests/html/browsers/the-window-object from upstream

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Chris Dumez]

Resync web-platform-tests/html/browsers/the-window-object from upstream 552bd3bf8bc1be.

[Chris Dumez]

Created attachment 377262 [details]
Patch

[youenn fablet]

Comment on attachment 377262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377262&action=review

> LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/noopener-noreferrer-BarProp.window-expected.txt:4
> +FAIL window.open() with noreferrer should have all bars visible Can't find variable: BroadcastChannel

Should we skip it since we do not support BroadcastChannel or is the first PASS useful?
Should we rewrite the tests without BroadcastChannel?

> LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/noopener-noreferrer-sizing.window-expected.txt:3
> +FAIL window.open() with noreferrer should have equal viewport width and height Can't find variable: BroadcastChannel

Ditto.

[Chris Dumez]

Comment on attachment 377262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377262&action=review

>> LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/noopener-noreferrer-BarProp.window-expected.txt:4
>> +FAIL window.open() with noreferrer should have all bars visible Can't find variable: BroadcastChannel
> 
> Should we skip it since we do not support BroadcastChannel or is the first PASS useful?
> Should we rewrite the tests without BroadcastChannel?

It fails quickly so I do not see any reason to skip it. Also, one of the checks actually runs successfully so we at least get some coverage.

>> LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/noopener-noreferrer-sizing.window-expected.txt:3
>> +FAIL window.open() with noreferrer should have equal viewport width and height Can't find variable: BroadcastChannel
> 
> Ditto.

It fails quickly so I do not see any reason to skip it.

[WebKit Commit Bot]

Comment on attachment 377262 [details]
Patch

Rejecting attachment 377262 [details] from commit-queue.

New failing tests:
imported/w3c/web-platform-tests/html/browsers/the-window-object/noopener-noreferrer-BarProp.window.html
Full output: https://webkit-queues.webkit.org/results/12970174

[WebKit Commit Bot]

Created attachment 377273 [details]
Archive of layout-test-results from webkit-cq-01 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Comment on attachment 377262 [details]
Patch

Rejecting attachment 377262 [details] from commit-queue.

New failing tests:
imported/w3c/web-platform-tests/html/browsers/the-window-object/noopener-noreferrer-BarProp.window.html
Full output: https://webkit-queues.webkit.org/results/12970385

[WebKit Commit Bot]

Created attachment 377281 [details]
Archive of layout-test-results from webkit-cq-03 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Chris Dumez]

Created attachment 377282 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 377282 [details]
Patch

Clearing flags on attachment: 377282

Committed r249123: <https://trac.webkit.org/changeset/249123>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54727310>