Bug 200882 - Change default value of window.open()'s url argument
Summary: Change default value of window.open()'s url argument
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 201145
Blocks:
  Show dependency tree / graph
 
Reported: 2019-08-19 03:02 PDT by Anne van Kesteren
Modified: 2019-08-26 20:20 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.38 KB, patch)
2019-08-26 13:03 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (3.38 KB, patch)
2019-08-26 16:47 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anne van Kesteren 2019-08-19 03:02:03 PDT 
Per discussion in https://github.com/whatwg/html/issues/4762.
Comment 1 Anne van Kesteren 2019-08-19 04:48:03 PDT 
There's a test up for review at https://github.com/web-platform-tests/wpt/pull/18536.
Comment 2 Chris Dumez 2019-08-26 13:03:31 PDT 
Created attachment 377263 [details]
Patch
Comment 3 Ryosuke Niwa 2019-08-26 13:48:54 PDT 
Are you updating the patch for trunk?
Comment 4 Chris Dumez 2019-08-26 13:53:20 PDT 
(In reply to Ryosuke Niwa from comment #3)
> Are you updating the patch for trunk?

The patch is fine, the dependency bug just needs to land first.
Comment 5 Ryosuke Niwa 2019-08-26 13:57:45 PDT 
Comment on attachment 377263 [details]
Patch

Ok, please be sure to have the new patch go through EWS to catch any unexpectedly failing tests.
Comment 6 Chris Dumez 2019-08-26 14:07:33 PDT 
(In reply to Ryosuke Niwa from comment #5)
> Comment on attachment 377263 [details]
> Patch
> 
> Ok, please be sure to have the new patch go through EWS to catch any
> unexpectedly failing tests.

Sure thing, thanks.
Comment 7 Chris Dumez 2019-08-26 16:47:51 PDT 
Created attachment 377290 [details]
Patch
Comment 8 WebKit Commit Bot 2019-08-26 20:19:13 PDT 
Comment on attachment 377290 [details]
Patch

Clearing flags on attachment: 377290

Committed r249130: <https://trac.webkit.org/changeset/249130>
Comment 9 WebKit Commit Bot 2019-08-26 20:19:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-08-26 20:20:21 PDT 
<rdar://problem/54733725>