Bug 200991 - Crash under StringImpl::endsWith() in RegistrationDatabase::openSQLiteDatabase()
Summary: Crash under StringImpl::endsWith() in RegistrationDatabase::openSQLiteDatabase()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-21 12:24 PDT by Chris Dumez
Modified: 2019-08-21 15:17 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.22 KB, patch)
2019-08-21 12:32 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-08-21 12:24:07 PDT
Crash under StringImpl::endsWith() in RegistrationDatabase::openSQLiteDatabase():
Thread 7 name:  Dispatch queue: ServiceWorker I/O Thread
Thread 7 Crashed ↩:
0   JavaScriptCore                	0x00000001b6f0a3bc WTF::StringImpl::endsWith(unsigned short) const + 24 (StringImpl.h:1100)
1   JavaScriptCore                	0x00000001b6ee6298 WTF::FileSystemImpl::pathByAppendingComponent(WTF::String const&, WTF::String const&) + 52 (WTFString.h:221)
2   WebCore                       	0x00000001b1823b3c WebCore::RegistrationDatabase::openSQLiteDatabase(WTF::String const&) + 92 (RegistrationDatabase.cpp:93)
3   WebCore                       	0x00000001b18256a8 WebCore::RegistrationDatabase::doPushChanges(WTF::Vector<WebCore::ServiceWorkerContextData, 0ul, WTF::CrashOnOverflow, 16ul>&&) + 96 (RegistrationDatabase.cpp:311)
4   WebCore                       	0x00000001b182aa30 WTF::Detail::CallableWrapper<WebCore::RegistrationDatabase::pushChanges(WTF::Vector<WebCore::ServiceWorkerContextData, 0ul, WTF::CrashOnOverflow, 16ul>&&, WTF::CompletionHandler<void ()>&&)::$_23, void>::call() + 32 (RegistrationDatabase.cpp:279)
5   libdispatch.dylib             	0x00000001a81ae658 _dispatch_call_block_and_release + 24 (init.c:1408)
6   libdispatch.dylib             	0x00000001a81af1cc _dispatch_client_callout + 16 (object.m:495)
7   libdispatch.dylib             	0x00000001a815b524 _dispatch_lane_serial_drain$VARIANT$mp + 608 (inline_internal.h:2487)
8   libdispatch.dylib             	0x00000001a815bf18 _dispatch_lane_invoke$VARIANT$mp + 420 (queue.c:3820)
9   libdispatch.dylib             	0x00000001a8165400 _dispatch_workloop_worker_thread + 588 (queue.c:6380)
10  libsystem_pthread.dylib       	0x00000001a81fefa8 _pthread_wqthread + 276 (pthread.c:2323)
11  libsystem_pthread.dylib       	0x00000001a8201ae4 start_wqthread + 8
Comment 1 Radar WebKit Bug Importer 2019-08-21 12:24:26 PDT
<rdar://problem/54566689>
Comment 2 Chris Dumez 2019-08-21 12:32:35 PDT
Created attachment 376905 [details]
Patch
Comment 3 Geoffrey Garen 2019-08-21 14:15:10 PDT
Comment on attachment 376905 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2019-08-21 15:17:13 PDT
The commit-queue encountered the following flaky tests while processing attachment 376905 [details]:

media/remote-control-command-seek.html bug 192381 (authors: eric.carlson@apple.com and graouts@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2019-08-21 15:17:55 PDT
Comment on attachment 376905 [details]
Patch

Clearing flags on attachment: 376905

Committed r248967: <https://trac.webkit.org/changeset/248967>
Comment 6 WebKit Commit Bot 2019-08-21 15:17:56 PDT
All reviewed patches have been landed.  Closing bug.