Bug 200970 - [Win][MiniBrowser] Add a progress indicator to the main window
Summary: [Win][MiniBrowser] Add a progress indicator to the main window
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-21 01:28 PDT by Fujii Hironori
Modified: 2019-09-08 23:47 PDT (History)
6 users (show)

See Also:

Attachments
WIP patch (12.32 KB, patch)
2019-08-21 01:30 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (18.64 KB, patch)
2019-08-21 03:03 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-08-21 01:28:01 PDT 
[Win][MiniBrowser] Add a progress indicator to the main window
Comment 1 Fujii Hironori 2019-08-21 01:30:31 PDT 
Created attachment 376854 [details]
WIP patch
Comment 2 Fujii Hironori 2019-08-21 03:03:40 PDT 
Created attachment 376857 [details]
Patch
Comment 3 Fujii Hironori 2019-08-21 03:28:36 PDT 
screenshot: https://ibb.co/KjRPZ8X
Comment 4 Fujii Hironori 2019-08-21 18:50:20 PDT 
Comment on attachment 376857 [details]
Patch

Clearing flags on attachment: 376857

Committed r248990: <https://trac.webkit.org/changeset/248990>
Comment 5 Fujii Hironori 2019-08-21 18:50:23 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-21 18:51:19 PDT 
<rdar://problem/54582290>
Comment 7 Fujii Hironori 2019-09-08 23:47:08 PDT 
Comment on attachment 376857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376857&action=review

> Tools/MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:142
> +    hr = defaultNotificationCenter->addObserver(webHost, _bstr_t(WebViewProgressEstimateChangedNotification), nullptr);

I should call removeObserver elsewhere to avoid leakage. I'm going to fix it in Bug 201600.