Bug 201600 - [Win][MiniBrowser] WebKitLegacyBrowserWindow is leaked by circular references
Summary: [Win][MiniBrowser] WebKitLegacyBrowserWindow is leaked by circular references
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
: 201541 (view as bug list)
Depends on:
Blocks: 201541
  Show dependency tree / graph
 
Reported: 2019-09-08 23:02 PDT by Fujii Hironori
Modified: 2019-09-09 18:32 PDT (History)
6 users (show)

See Also:

Attachments
Patch (16.78 KB, patch)
2019-09-08 23:20 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-09-08 23:02:35 PDT 
[Win][MiniBrowser] WebKitLegacyBrowserWindow is leaked by circular references

There are some circular references. For example,
WebKitLegacyBrowserWindow has a reference of WebDownloadDelegate,
and WebDownloadDelegate shares ref counter with
WebKitLegacyBrowserWindow.
Comment 1 Fujii Hironori 2019-09-08 23:20:38 PDT 
Created attachment 378348 [details]
Patch
Comment 2 Fujii Hironori 2019-09-09 18:31:43 PDT 
Comment on attachment 378348 [details]
Patch

Clearing flags on attachment: 378348

Committed r249683: <https://trac.webkit.org/changeset/249683>
Comment 3 Fujii Hironori 2019-09-09 18:31:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Fujii Hironori 2019-09-09 18:32:10 PDT 
*** Bug 201541 has been marked as a duplicate of this bug. ***
Comment 5 Radar WebKit Bug Importer 2019-09-09 18:32:18 PDT 
<rdar://problem/55207246>