Bug 200795 – [results.webkit.org Timeline] Sticky Axis and new axis style

• Status: NEW
• Component: Tools / Tests

[Zhifei Fang]

[results.webkit.org Timeline] Sticky Axis and new axis style

[Zhifei Fang]

Created attachment 376439 [details]
Patch

[Jonathan Bedard]

Comment on attachment 376439 [details]
Patch

A few high level comments:
- I think I like the sticky scales, but I can see some people not liking them. I think we need to be able to disable the sticky scales.
- Before, the gap between multi-dot scales just didn't exist....now it feels too large.

I'm interested bot watcher's opinions on this, I'm deploying it to the staging instance now.

[Zhifei Fang]

(In reply to Jonathan Bedard from comment #2)
> Comment on attachment 376439 [details]
> Patch
> 
> A few high level comments:
> - I think I like the sticky scales, but I can see some people not liking
> them. I think we need to be able to disable the sticky scales.

Yes, you can disable it, I have designed an option to enable/disable it, by default it will be enable, so that we don't need to touch any existing code to enable it.

We can provide the UI to enable or disable it.

> - Before, the gap between multi-dot scales just didn't exist....now it feels
> too large.

Yeah, I want bot watchers' opinions on this as well, this change addressed what I remembered for Alexey's feedback. 

> 
> I'm interested bot watcher's opinions on this, I'm deploying it to the
> staging instance now.

[Zhifei Fang]

Created attachment 376462 [details]
Patch

[Zhifei Fang]

A small fix, will deploy this.

(In reply to Zhifei Fang from comment #4)
> Created attachment 376462 [details]
> Patch

[Zhifei Fang]

Created attachment 376465 [details]
Patch

[Jonathan Bedard]

If you scroll all the way to the right, the scale labels don't line up with their dots.

[Zhifei Fang]

Created attachment 376545 [details]
Patch

[Jonathan Bedard]

Comment on attachment 376545 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376545&action=review

> Tools/resultsdbpy/resultsdbpy/view/templates/base.html:56
> +    disableBackGesture();

Can we just make this a stand-alone patch? I recognize this is useful for the particular changes being made here, but it can also stand alone.

[Zhifei Fang]

(In reply to Jonathan Bedard from comment #9)
> Comment on attachment 376545 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=376545&action=review
> 
> > Tools/resultsdbpy/resultsdbpy/view/templates/base.html:56
> > +    disableBackGesture();
> 
> Can we just make this a stand-alone patch? I recognize this is useful for
> the particular changes being made here, but it can also stand alone.

Sure. Will do

[Zhifei Fang]

(In reply to Jonathan Bedard from comment #9)
> Comment on attachment 376545 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=376545&action=review
> 
> > Tools/resultsdbpy/resultsdbpy/view/templates/base.html:56
> > +    disableBackGesture();
> 
> Can we just make this a stand-alone patch? I recognize this is useful for
> the particular changes being made here, but it can also stand alone.

https://bugs.webkit.org/show_bug.cgi?id=200839

[Zhifei Fang]

Created attachment 376715 [details]
Patch

[Zhifei Fang]

Created attachment 376718 [details]
Patch

[Zhifei Fang]

Created attachment 376794 [details]
Patch