Bug 200839 - [results.webkit.org Timeline] Disable back gesture
Summary: [results.webkit.org Timeline] Disable back gesture
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-16 16:07 PDT by Zhifei Fang
Modified: 2019-08-19 11:10 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.30 KB, patch)
2019-08-16 16:10 PDT, Zhifei Fang 		no flags Details | Formatted Diff | Diff
Patch (2.24 KB, patch)
2019-08-16 18:08 PDT, Zhifei Fang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zhifei Fang 2019-08-16 16:07:13 PDT 
Disable back gesture, so that when user scroll, it won't be accidentally back to the pervious page, this is supper annoying, and create a bad UX.
Comment 1 Zhifei Fang 2019-08-16 16:10:39 PDT 
Created attachment 376557 [details]
Patch
Comment 2 Jonathan Bedard 2019-08-16 16:32:39 PDT 
Comment on attachment 376557 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376557&action=review

> Tools/resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:92
> +        //console.log(e);

Did we forget to remove this?

> Tools/resultsdbpy/resultsdbpy/view/templates/base.html:54
> +    // This will disable back gesture

We don't need the comment, function name is enough.
Comment 3 Zhifei Fang 2019-08-16 18:08:53 PDT 
Created attachment 376572 [details]
Patch
Comment 4 WebKit Commit Bot 2019-08-19 11:09:47 PDT 
Comment on attachment 376572 [details]
Patch

Clearing flags on attachment: 376572

Committed r248859: <https://trac.webkit.org/changeset/248859>
Comment 5 WebKit Commit Bot 2019-08-19 11:09:50 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-19 11:10:21 PDT 
<rdar://problem/54474386>