WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
200839
[results.webkit.org Timeline] Disable back gesture
https://bugs.webkit.org/show_bug.cgi?id=200839
Summary
[results.webkit.org Timeline] Disable back gesture
Zhifei Fang
Reported
2019-08-16 16:07:13 PDT
Disable back gesture, so that when user scroll, it won't be accidentally back to the pervious page, this is supper annoying, and create a bad UX.
Attachments
Patch
(2.30 KB, patch)
2019-08-16 16:10 PDT
,
Zhifei Fang
no flags
Details
Formatted Diff
Diff
Patch
(2.24 KB, patch)
2019-08-16 18:08 PDT
,
Zhifei Fang
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Zhifei Fang
Comment 1
2019-08-16 16:10:39 PDT
Created
attachment 376557
[details]
Patch
Jonathan Bedard
Comment 2
2019-08-16 16:32:39 PDT
Comment on
attachment 376557
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=376557&action=review
> Tools/resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:92 > + //console.log(e);
Did we forget to remove this?
> Tools/resultsdbpy/resultsdbpy/view/templates/base.html:54 > + // This will disable back gesture
We don't need the comment, function name is enough.
Zhifei Fang
Comment 3
2019-08-16 18:08:53 PDT
Created
attachment 376572
[details]
Patch
WebKit Commit Bot
Comment 4
2019-08-19 11:09:47 PDT
Comment on
attachment 376572
[details]
Patch Clearing flags on attachment: 376572 Committed
r248859
: <
https://trac.webkit.org/changeset/248859
>
WebKit Commit Bot
Comment 5
2019-08-19 11:09:50 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6
2019-08-19 11:10:21 PDT
<
rdar://problem/54474386
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug