Bug 200400 – New EWS:mac-wk2 status-bubble shows waiting to run tests for all recent bugs

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

The patch for bug #199960 (attachment #374973 [details]) has been waiting for a Mac WK1 tester for 7 days now.

[Daniel Bates]

Created attachment 375436 [details]
Bubble status

[Radar WebKit Bug Importer]

<rdar://problem/53872439>

[Daniel Bates]

Created attachment 375437 [details]
EWS Mac-wk2 status page

<https://ews-build.webkit.org/#/builders/7/builds/5822>

[Daniel Bates]

Created attachment 375438 [details]
Tooltip when you hover over Mac-wk2 bubble

[Aakash Jain]

This is true for patches since April (when new EWS started building patches on ios and mac) 
e.g.: https://bugs.webkit.org/show_bug.cgi?id=198058

[Aakash Jain]

Note that we haven't yet moved WK1 queues to production yet, so kindly ignore the buildbot page showing WK1 build triggers.

[Aakash Jain]

We moved mac-wk2 queue to production only 2 days back, so it wouldn't be processing any older patches. Ideally these bubbles should be hidden, since those patch were uploaded before the queue started in production.

After the change in bug 200333, the tester queues started showing information from builder queue as well (while tester queue hasn't started processing it). This has an unintentional side-effect of showing bubbles which should have been hidden.

[Aakash Jain]

For bug #199960 I have pressed the 'Rebuild' button on the corresponding build (https://ews-build.webkit.org/#/builders/7/builds/5822), so mac-wk2 queue should process it now.

[Aakash Jain]

*** Bug 200443 has been marked as a duplicate of this bug. ***

[Aakash Jain]

Created attachment 375549 [details]
Patch

[Aakash Jain]

(In reply to Aakash Jain from comment #10)
> Created attachment 375549 [details]
> Patch
This fix is similar to https://trac.webkit.org/changeset/244930/webkit
That one applies to builder queues. The triggered queues take a different code-path, as they check for parent_build (build on builder queue), and so do not use the _queue_position() method if parent_build is found.

[WebKit Commit Bot]

Comment on attachment 375549 [details]
Patch

Clearing flags on attachment: 375549

Committed r248272: <https://trac.webkit.org/changeset/248272>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.