Bug 200400 - New EWS:mac-wk2 status-bubble shows waiting to run tests for all recent bugs
Summary: New EWS:mac-wk2 status-bubble shows waiting to run tests for all recent bugs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
: 200443 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-08-02 11:46 PDT by Daniel Bates
Modified: 2019-08-05 14:24 PDT (History)
3 users (show)

See Also:


Attachments
Bubble status (300.72 KB, image/png)
2019-08-02 11:46 PDT, Daniel Bates
no flags Details
EWS Mac-wk2 status page (426.88 KB, image/png)
2019-08-02 11:48 PDT, Daniel Bates
no flags Details
Tooltip when you hover over Mac-wk2 bubble (176.80 KB, image/png)
2019-08-02 11:49 PDT, Daniel Bates
no flags Details
Patch (2.63 KB, patch)
2019-08-05 13:36 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-08-02 11:46:21 PDT
The patch for bug #199960 (attachment #374973 [details]) has been waiting for a Mac WK1 tester for 7 days now.
Comment 1 Daniel Bates 2019-08-02 11:46:54 PDT
Created attachment 375436 [details]
Bubble status
Comment 2 Radar WebKit Bug Importer 2019-08-02 11:48:20 PDT
<rdar://problem/53872439>
Comment 3 Daniel Bates 2019-08-02 11:48:30 PDT
Created attachment 375437 [details]
EWS Mac-wk2 status page

<https://ews-build.webkit.org/#/builders/7/builds/5822>
Comment 4 Daniel Bates 2019-08-02 11:49:55 PDT
Created attachment 375438 [details]
Tooltip when you hover over Mac-wk2 bubble
Comment 5 Aakash Jain 2019-08-02 12:07:03 PDT
This is true for patches since April (when new EWS started building patches on ios and mac) 
e.g.: https://bugs.webkit.org/show_bug.cgi?id=198058
Comment 6 Aakash Jain 2019-08-02 12:13:51 PDT
Note that we haven't yet moved WK1 queues to production yet, so kindly ignore the buildbot page showing WK1 build triggers.
Comment 7 Aakash Jain 2019-08-02 12:14:40 PDT
We moved mac-wk2 queue to production only 2 days back, so it wouldn't be processing any older patches. Ideally these bubbles should be hidden, since those patch were uploaded before the queue started in production.

After the change in bug 200333, the tester queues started showing information from builder queue as well (while tester queue hasn't started processing it). This has an unintentional side-effect of showing bubbles which should have been hidden.
Comment 8 Aakash Jain 2019-08-02 12:17:24 PDT
For bug #199960 I have pressed the 'Rebuild' button on the corresponding build (https://ews-build.webkit.org/#/builders/7/builds/5822), so mac-wk2 queue should process it now.
Comment 9 Aakash Jain 2019-08-05 13:33:42 PDT
*** Bug 200443 has been marked as a duplicate of this bug. ***
Comment 10 Aakash Jain 2019-08-05 13:36:47 PDT
Created attachment 375549 [details]
Patch
Comment 11 Aakash Jain 2019-08-05 13:39:44 PDT
(In reply to Aakash Jain from comment #10)
> Created attachment 375549 [details]
> Patch
This fix is similar to https://trac.webkit.org/changeset/244930/webkit
That one applies to builder queues. The triggered queues take a different code-path, as they check for parent_build (build on builder queue), and so do not use the _queue_position() method if parent_build is found.
Comment 12 WebKit Commit Bot 2019-08-05 14:24:57 PDT
Comment on attachment 375549 [details]
Patch

Clearing flags on attachment: 375549

Committed r248272: <https://trac.webkit.org/changeset/248272>
Comment 13 WebKit Commit Bot 2019-08-05 14:24:59 PDT
All reviewed patches have been landed.  Closing bug.