WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
200333
New EWS: Cannot see build status page when patch is waiting for tester
https://bugs.webkit.org/show_bug.cgi?id=200333
Summary
New EWS: Cannot see build status page when patch is waiting for tester
Daniel Bates
Reported
2019-07-31 20:33:51 PDT
Created
attachment 375284
[details]
Screenshot Looking through patches and I noticed came to <
https://bugs.webkit.org/show_bug.cgi?id=200324
>. It's
attachment #375282
[details]
, is #61 in the mac-wk2 queue and this info is displayed in a white bubble. Clicking on this button does nothing so I cannot make heads or tails what the status is on my iPad. As it turns out, the patch was built, <
https://ews-build.webkit.org/#/builders/7/builds/6118
>, and triggered testers and is waiting on them. Can we have the white bubble link to the build page at least when a patch is waiting in a triggered queue? It's infuriating to see an unclickable white bubble in my opinion.
Attachments
Screenshot
(705.38 KB, image/png)
2019-07-31 20:33 PDT
,
Daniel Bates
no flags
Details
Waiting for worker....
(638.93 KB, image/png)
2019-07-31 20:36 PDT
,
Daniel Bates
no flags
Details
Patch
(1.39 KB, patch)
2019-08-01 04:56 PDT
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2019-07-31 20:34:06 PDT
<
rdar://problem/53794843
>
Daniel Bates
Comment 2
2019-07-31 20:35:05 PDT
FYI Old EWS linked white bubbles to a status page.
Daniel Bates
Comment 3
2019-07-31 20:36:16 PDT
Created
attachment 375285
[details]
Waiting for worker....
Aakash Jain
Comment 4
2019-08-01 04:56:16 PDT
Created
attachment 375305
[details]
Patch
Aakash Jain
Comment 5
2019-08-01 05:03:59 PDT
Thanks Dan for the feedback. We did similar thing in
https://trac.webkit.org/changeset/243914
for api tests queues, extending that logic to these queues as well.
Jonathan Bedard
Comment 6
2019-08-01 07:48:59 PDT
To clarify what's going on with this change: We already have the logic to link test runs which are waiting on their builder together, we just hadn't taught EWS which builders belong to which testers, correct?
WebKit Commit Bot
Comment 7
2019-08-01 08:14:22 PDT
Comment on
attachment 375305
[details]
Patch Clearing flags on attachment: 375305 Committed
r248103
: <
https://trac.webkit.org/changeset/248103
>
WebKit Commit Bot
Comment 8
2019-08-01 08:14:23 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug