Bug 200333 - New EWS: Cannot see build status page when patch is waiting for tester
Summary: New EWS: Cannot see build status page when patch is waiting for tester
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Keywords: InRadar
Depends on:
Reported: 2019-07-31 20:33 PDT by Daniel Bates
Modified: 2019-08-01 08:14 PDT (History)
5 users (show)

See Also:

Screenshot (705.38 KB, image/png)
2019-07-31 20:33 PDT, Daniel Bates
no flags Details
Waiting for worker.... (638.93 KB, image/png)
2019-07-31 20:36 PDT, Daniel Bates
no flags Details
Patch (1.39 KB, patch)
2019-08-01 04:56 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-07-31 20:33:51 PDT
Created attachment 375284 [details]

Looking through patches and I noticed came to <https://bugs.webkit.org/show_bug.cgi?id=200324>. It's attachment #375282 [details], is #61 in the mac-wk2 queue and this info is displayed in a white bubble. Clicking on this button does nothing so I cannot make heads or tails what the status is on my iPad.

As it turns out, the patch was built, <https://ews-build.webkit.org/#/builders/7/builds/6118>, and triggered testers and is waiting on them. Can we have the white bubble link to the build page at least when a patch is waiting in a triggered queue? It's infuriating to see an unclickable white bubble in my opinion.
Comment 1 Radar WebKit Bug Importer 2019-07-31 20:34:06 PDT
Comment 2 Daniel Bates 2019-07-31 20:35:05 PDT
FYI Old EWS linked white bubbles to a status page.
Comment 3 Daniel Bates 2019-07-31 20:36:16 PDT
Created attachment 375285 [details]
Waiting for worker....
Comment 4 Aakash Jain 2019-08-01 04:56:16 PDT
Created attachment 375305 [details]
Comment 5 Aakash Jain 2019-08-01 05:03:59 PDT
Thanks Dan for the feedback. 
We did similar thing in https://trac.webkit.org/changeset/243914 for api tests queues, extending that logic to these queues as well.
Comment 6 Jonathan Bedard 2019-08-01 07:48:59 PDT
To clarify what's going on with this change: We already have the logic to link test runs which are waiting on their builder together, we just hadn't taught EWS which builders belong to which testers, correct?
Comment 7 WebKit Commit Bot 2019-08-01 08:14:22 PDT
Comment on attachment 375305 [details]

Clearing flags on attachment: 375305

Committed r248103: <https://trac.webkit.org/changeset/248103>
Comment 8 WebKit Commit Bot 2019-08-01 08:14:23 PDT
All reviewed patches have been landed.  Closing bug.