Bug 200311 - Update TestWebKitAPI for XCBuild
Summary: Update TestWebKitAPI for XCBuild
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
Keywords: InRadar
Depends on:
Reported: 2019-07-31 12:23 PDT by Keith Rollin
Modified: 2019-08-01 10:52 PDT (History)
6 users (show)

See Also:

Patch (12.08 KB, patch)
2019-07-31 12:29 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff
Patch (12.08 KB, patch)
2019-07-31 13:55 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff
Patch (10.50 KB, patch)
2019-07-31 14:27 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-07-31 12:23:38 PDT
Bug 199728 (svn 247402) updated TestWebKitAPI to use the unified-build technique. Now update WebKitLegacy to build under XCBuild after those changes. This work involves adding an "Apply Configuration to XCFileLists" build target, adding a check-xcfilelists.sh script, adding a "Check xcfilelists" build phase that calls that script, adding knowledge of the project to the generate-xcfilelists script, creating new .xcfilelist files, and adding those to the project.
Comment 1 Radar WebKit Bug Importer 2019-07-31 12:23:51 PDT
Comment 2 Keith Rollin 2019-07-31 12:29:50 PDT
Created attachment 375234 [details]
Comment 3 Keith Rollin 2019-07-31 12:31:36 PDT
Oops. The patch doesn't apply?
Comment 4 Keith Rollin 2019-07-31 12:32:33 PDT
Oh. I know why. Bug 200310 needs to land first.
Comment 5 Keith Rollin 2019-07-31 12:40:24 PDT
FYI, this patch parallels that for Bug 200310.
Comment 6 Keith Rollin 2019-07-31 13:55:02 PDT
Created attachment 375240 [details]
Comment 7 Keith Rollin 2019-07-31 13:55:45 PDT
Bug 200310 has landed, so re-uploaded the patch for this bug for EWS purposes.
Comment 8 Keith Rollin 2019-07-31 13:57:37 PDT
Now what?
Comment 9 Keith Rollin 2019-07-31 14:27:41 PDT
Created attachment 375244 [details]
Comment 10 Keith Rollin 2019-07-31 14:28:04 PDT
OK, I rebased on ToT it locally, so it should apply now.
Comment 11 WebKit Commit Bot 2019-08-01 10:52:07 PDT
Comment on attachment 375244 [details]

Clearing flags on attachment: 375244

Committed r248106: <https://trac.webkit.org/changeset/248106>
Comment 12 WebKit Commit Bot 2019-08-01 10:52:09 PDT
All reviewed patches have been landed.  Closing bug.