RESOLVED FIXED 199728
Begin unifying TestWebKitAPI build 
https://bugs.webkit.org/show_bug.cgi?id=199728
Summary Begin unifying TestWebKitAPI build
Alex Christensen
Reported 2019-07-11 14:40:03 PDT
Begin unifying TestWebKitAPI build
Attachments
Patch (32.79 KB, patch)
2019-07-11 14:42 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-07-11 14:42:58 PDT
Created attachment 373959 [details] Patch
Keith Miller
Comment 2 2019-07-12 14:10:40 PDT
Comment on attachment 373959 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373959&action=review r=me with comment. > Tools/TestWebKitAPI/Scripts/generate-unified-sources.sh:21 > + echo "Using unified source list files: Sources.txt, SourcesCocoa.txt" Is there a way to make this echo use the same values that are passed to the generate-unified-source-bundles.rb call below?
Alex Christensen
Comment 3 2019-07-12 14:16:47 PDT
If that's important we should make JavaScriptCore and WebCore do the same thing in a different patch.
WebKit Commit Bot
Comment 4 2019-07-12 15:13:05 PDT
Comment on attachment 373959 [details] Patch Clearing flags on attachment: 373959 Committed r247402: <https://trac.webkit.org/changeset/247402>
WebKit Commit Bot
Comment 5 2019-07-12 15:13:06 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-07-12 15:14:18 PDT
<rdar://problem/53029476>
Note You need to log in before you can comment on or make changes to this bug.