Bug 199728 - Begin unifying TestWebKitAPI build
Summary: Begin unifying TestWebKitAPI build
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
Keywords: InRadar
Depends on:
Reported: 2019-07-11 14:40 PDT by Alex Christensen
Modified: 2019-07-12 15:14 PDT (History)
3 users (show)

See Also:

Patch (32.79 KB, patch)
2019-07-11 14:42 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-07-11 14:40:03 PDT
Begin unifying TestWebKitAPI build
Comment 1 Alex Christensen 2019-07-11 14:42:58 PDT
Created attachment 373959 [details]
Comment 2 Keith Miller 2019-07-12 14:10:40 PDT
Comment on attachment 373959 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=373959&action=review

r=me with comment.

> Tools/TestWebKitAPI/Scripts/generate-unified-sources.sh:21
> +    echo "Using unified source list files: Sources.txt, SourcesCocoa.txt"

Is there a way to make this echo use the same values that are passed to the generate-unified-source-bundles.rb call below?
Comment 3 Alex Christensen 2019-07-12 14:16:47 PDT
If that's important we should make JavaScriptCore and WebCore do the same thing in a different patch.
Comment 4 WebKit Commit Bot 2019-07-12 15:13:05 PDT
Comment on attachment 373959 [details]

Clearing flags on attachment: 373959

Committed r247402: <https://trac.webkit.org/changeset/247402>
Comment 5 WebKit Commit Bot 2019-07-12 15:13:06 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-07-12 15:14:18 PDT