200245 – Add layout test coverage for <https://webkit.org/b/200215>

RESOLVED FIXED Bug 200245

Add layout test coverage for <https://webkit.org/b/200215>

https://bugs.webkit.org/show_bug.cgi?id=200245

Summary Add layout test coverage for <https://webkit.org/b/200215>

Wenson Hsieh

Reported 2019-07-29 14:53:50 PDT

SSIA

Attachments
Patch (14.58 KB, patch) 2019-07-29 15:11 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Remove unused member variable (13.97 KB, patch) 2019-07-29 15:14 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (1.21 MB, application/zip) 2019-07-29 16:15 PDT, EWS Watchlist	no flags	Details
Patch for landing (13.99 KB, patch) 2019-07-29 16:55 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Patch for landing (13.98 KB, patch) 2019-07-29 18:33 PDT, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2019-07-29 15:11:27 PDT Comment hidden (obsolete)

Created attachment 375109 [details] Patch

Wenson Hsieh

Comment 2 2019-07-29 15:14:33 PDT

Created attachment 375110 [details] Remove unused member variable

EWS Watchlist

Comment 3 2019-07-29 16:15:13 PDT Comment hidden (obsolete)

Comment on attachment 375110 [details] Remove unused member variable Attachment 375110 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12832436 Number of test failures exceeded the failure limit.

EWS Watchlist

Comment 4 2019-07-29 16:15:14 PDT Comment hidden (obsolete)

Created attachment 375119 [details] Archive of layout-test-results from ews107 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Wenson Hsieh

Comment 5 2019-07-29 16:51:46 PDT Comment hidden (obsolete)

Comment on attachment 375110 [details] Remove unused member variable View in context: https://bugs.webkit.org/attachment.cgi?id=375110&action=review > Tools/WebKitTestRunner/TestInvocation.cpp:1865 > + if (m_UIScriptContext->callbackWithID(CallbackTypeWillCreateNewPage)) Oops, this doesn’t work the way I thought it did.

Wenson Hsieh

Comment 6 2019-07-29 16:55:45 PDT Comment hidden (obsolete)

Created attachment 375128 [details] Patch for landing

WebKit Commit Bot

Comment 7 2019-07-29 18:20:21 PDT Comment hidden (obsolete)

Comment on attachment 375128 [details] Patch for landing Rejecting attachment 375128 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 375128, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/12833301

Wenson Hsieh

Comment 8 2019-07-29 18:33:07 PDT

Created attachment 375134 [details] Patch for landing

WebKit Commit Bot

Comment 9 2019-07-29 20:44:07 PDT

Comment on attachment 375134 [details] Patch for landing Clearing flags on attachment: 375134 Committed r247941: <https://trac.webkit.org/changeset/247941>

WebKit Commit Bot

Comment 10 2019-07-29 20:44:09 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component HTML Editing

Assignee

Wenson Hsieh

Reported

2019-07-29 14:53 PDT

Modified

2019-07-29 20:44 PDT History

CC List

8 users Show

URL

Keywords DoNotImportToRadar

Depends on

Blocks