Bug 200215 - UI process occasionally hangs in -[UIKeyboardTaskQueue lockWhenReadyForMainThread]
Summary: UI process occasionally hangs in -[UIKeyboardTaskQueue lockWhenReadyForMainTh...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-28 21:40 PDT by Wenson Hsieh
Modified: 2019-07-29 15:27 PDT (History)
8 users (show)

See Also:


Attachments
Patch (30.01 KB, patch)
2019-07-28 22:48 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Patch (29.92 KB, patch)
2019-07-28 22:54 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Much simpler approach (5.93 KB, patch)
2019-07-29 07:52 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-07-28 21:40:56 PDT
<rdar://problem/52976965>
Comment 1 Wenson Hsieh 2019-07-28 22:48:54 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2019-07-28 22:54:10 PDT Comment hidden (obsolete)
Comment 3 Maciej Stachowiak 2019-07-29 00:53:38 PDT
Comment on attachment 375062 [details]
Patch

Is there a way to make a test case for this fix?
Comment 4 Wenson Hsieh 2019-07-29 07:25:23 PDT
(In reply to Maciej Stachowiak from comment #3)
> Comment on attachment 375062 [details]
> Patch
> 
> Is there a way to make a test case for this fix?

It should be doable but…tricky, since the bug as-is relies on code in Safari. I’ll need to find a way to mock this either from layout tests, or API tests.
Comment 5 Wenson Hsieh 2019-07-29 07:52:30 PDT
Created attachment 375074 [details]
Much simpler approach
Comment 6 Tim Horton 2019-07-29 11:41:16 PDT
Wenson is working on a test for a follow-up.
Comment 7 Wenson Hsieh 2019-07-29 11:41:52 PDT
Comment on attachment 375074 [details]
Much simpler approach

Thanks for the review!

I’m working on a test right now, which I’ll land in a separate patch.
Comment 8 WebKit Commit Bot 2019-07-29 12:12:47 PDT
Comment on attachment 375074 [details]
Much simpler approach

Clearing flags on attachment: 375074

Committed r247914: <https://trac.webkit.org/changeset/247914>
Comment 9 WebKit Commit Bot 2019-07-29 12:12:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Wenson Hsieh 2019-07-29 15:27:54 PDT
(In reply to Wenson Hsieh from comment #7)
> Comment on attachment 375074 [details]
> Much simpler approach
> 
> Thanks for the review!
> 
> I’m working on a test right now, which I’ll land in a separate patch.

=> webkit.org/b/200245