Bug 200142 - results.webkit.org: Support multiple build links for a given bubble
Summary: results.webkit.org: Support multiple build links for a given bubble
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-25 15:59 PDT by Jonathan Bedard
Modified: 2019-07-26 12:02 PDT (History)
1 user (show)

See Also:

Attachments
Patch (7.26 KB, patch)
2019-07-25 16:03 PDT, Jonathan Bedard 		jbedard: review?
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-07-25 15:59:35 PDT 
It's possible for a single bubble to be linked to multiple build links. We should support multiple redirects in this case.
Comment 1 Jonathan Bedard 2019-07-25 16:03:23 PDT 
Created attachment 374919 [details]
Patch
Comment 2 Jonathan Bedard 2019-07-25 16:10:57 PDT 
The possible downside of this approach is that if you don't do something to limit these endpoints, you could literally have hundreds of redirects. None of the links generated by the site would have hundreds of redirects, but it's something that the redirect endpoints could do.
Comment 3 Aakash Jain 2019-07-26 11:28:41 PDT 
Opening multiple urls on a single click would be a weird UX, and probably not what users expect. Another idea might be to show a pop-over containing all the links.
Comment 4 Jonathan Bedard 2019-07-26 12:02:52 PDT 
(In reply to Aakash Jain from comment #3)
> Opening multiple urls on a single click would be a weird UX, and probably
> not what users expect. Another idea might be to show a pop-over containing
> all the links.

If we think pop-over is the right approach, this is blocked on <https://bugs.webkit.org/show_bug.cgi?id=200172>. Since we'll have other data in pop-overs, we should probably shelve this change until we figure out our strategy with pop-overs.