Bug 200172 – results.webkit.org: Use canvas for timeline

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

Asking the browser to render large timelines is very slow. We have a canvas implementation of the timeline that we should use instead.

[Jonathan Bedard]

Created attachment 375371 [details]
Patch

[Jonathan Bedard]

Created attachment 375439 [details]
Patch

[Jonathan Bedard]

Created attachment 375454 [details]
Patch

[Jonathan Bedard]

Created attachment 375574 [details]
Patch

[Jonathan Bedard]

Created attachment 375638 [details]
Patch

[Zhifei Fang]

Comment on attachment 375638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375638&action=review

> Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js:368
>              }

Since now the element's children are multiple canvas, using element.innerHTML may cause some memory can not be gc, please use DOM.inject everywhere which will clean all the ref's reference, so that it can be gc finally.

> Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js:555
> +                // FIXME: We should do something sane here, but we probably need another endpoint

I guess we will need a popover ?

> Tools/resultsdbpy/resultsdbpy/view/templates/suite_results.html:66
>          this.children = {};

Same thing around here.

[Zhifei Fang]

unofficially r=me

[Jonathan Bedard]

Created attachment 375769 [details]
Patch

[Aakash Jain]

Comment on attachment 375769 [details]
Patch

rs=me

[Jonathan Bedard]

Created attachment 375811 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 375811 [details]
Patch for landing

Clearing flags on attachment: 375811

Committed r248425: <https://trac.webkit.org/changeset/248425>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54086870>