Bug 200172 - results.webkit.org: Use canvas for timeline
Summary: results.webkit.org: Use canvas for timeline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-26 12:01 PDT by Jonathan Bedard
Modified: 2019-08-08 10:54 PDT (History)
4 users (show)

See Also:


Attachments
Patch (50.25 KB, patch)
2019-08-01 17:41 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (50.21 KB, patch)
2019-08-02 11:51 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (50.29 KB, patch)
2019-08-02 14:13 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (50.29 KB, patch)
2019-08-05 15:58 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (53.79 KB, patch)
2019-08-06 11:54 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (54.51 KB, patch)
2019-08-07 17:15 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (54.57 KB, patch)
2019-08-08 10:11 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-07-26 12:01:00 PDT
Asking the browser to render large timelines is very slow. We have a canvas implementation of the timeline that we should use instead.
Comment 1 Jonathan Bedard 2019-08-01 17:41:59 PDT
Created attachment 375371 [details]
Patch
Comment 2 Jonathan Bedard 2019-08-02 11:51:52 PDT
Created attachment 375439 [details]
Patch
Comment 3 Jonathan Bedard 2019-08-02 14:13:11 PDT
Created attachment 375454 [details]
Patch
Comment 4 Jonathan Bedard 2019-08-05 15:58:19 PDT
Created attachment 375574 [details]
Patch
Comment 5 Jonathan Bedard 2019-08-06 11:54:18 PDT
Created attachment 375638 [details]
Patch
Comment 6 Zhifei Fang 2019-08-07 12:29:37 PDT
Comment on attachment 375638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375638&action=review

> Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js:368
>              }

Since now the element's children are multiple canvas, using element.innerHTML may cause some memory can not be gc, please use DOM.inject everywhere which will clean all the ref's reference, so that it can be gc finally.

> Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js:555
> +                // FIXME: We should do something sane here, but we probably need another endpoint

I guess we will need a popover ?

> Tools/resultsdbpy/resultsdbpy/view/templates/suite_results.html:66
>          this.children = {};

Same thing around here.
Comment 7 Zhifei Fang 2019-08-07 12:29:57 PDT
unofficially r=me
Comment 8 Jonathan Bedard 2019-08-07 17:15:33 PDT
Created attachment 375769 [details]
Patch
Comment 9 Aakash Jain 2019-08-08 08:15:49 PDT
Comment on attachment 375769 [details]
Patch

rs=me
Comment 10 Jonathan Bedard 2019-08-08 10:11:44 PDT
Created attachment 375811 [details]
Patch for landing
Comment 11 WebKit Commit Bot 2019-08-08 10:53:58 PDT
Comment on attachment 375811 [details]
Patch for landing

Clearing flags on attachment: 375811

Committed r248425: <https://trac.webkit.org/changeset/248425>
Comment 12 WebKit Commit Bot 2019-08-08 10:54:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 13 Radar WebKit Bug Importer 2019-08-08 10:54:16 PDT
<rdar://problem/54086870>