Bug 199956 - Move Ref.js to WebKit to support resultsdbpy's frontend
Summary: Move Ref.js to WebKit to support resultsdbpy's frontend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-19 12:14 PDT by Zhifei Fang
Modified: 2019-07-19 18:17 PDT (History)
5 users (show)

See Also:


Attachments
Patch (58.75 KB, patch)
2019-07-19 13:31 PDT, Zhifei Fang
no flags Details | Formatted Diff | Diff
Patch (67.27 KB, patch)
2019-07-19 15:07 PDT, Zhifei Fang
no flags Details | Formatted Diff | Diff
Patch (67.23 KB, patch)
2019-07-19 16:34 PDT, Zhifei Fang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zhifei Fang 2019-07-19 12:14:28 PDT
https://bugs.webkit.org/show_bug.cgi?id=199837
Comment 1 Zhifei Fang 2019-07-19 13:31:08 PDT
Created attachment 374491 [details]
Patch
Comment 2 Jonathan Bedard 2019-07-19 13:46:51 PDT
Comment on attachment 374491 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374491&action=review

> Tools/ChangeLog:3
> +        Move Ref.js to opensource to support resultsdbpy's frontend

Can we hook-up the resultsdbpy stuff while we're at it?

We also need to decide if these will be accessed with:
https://results.webkit.org/library/Ref.js (current behavior)
https://results.webkit.org/library/js/Ref.js
Comment 3 Zhifei Fang 2019-07-19 15:07:10 PDT
Created attachment 374500 [details]
Patch
Comment 4 Jonathan Bedard 2019-07-19 15:11:22 PDT
Comment on attachment 374500 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374500&action=review

> Tools/resultsdbpy/resultsdbpy/view/view_routes.py:-113
> -        AssertRequest.is_type()

We want to keep these asserts. This basically ensures that the request is a GET request with no queries, since anything else would be invalid.
Comment 5 Zhifei Fang 2019-07-19 16:34:12 PDT
Created attachment 374523 [details]
Patch
Comment 6 WebKit Commit Bot 2019-07-19 18:15:32 PDT
Comment on attachment 374523 [details]
Patch

Clearing flags on attachment: 374523

Committed r247664: <https://trac.webkit.org/changeset/247664>
Comment 7 WebKit Commit Bot 2019-07-19 18:15:33 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-07-19 18:17:31 PDT
<rdar://problem/53333184>