Bug 199837 - results.webkit.org: Move resultsdbpy to WebKit
Summary: results.webkit.org: Move resultsdbpy to WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-16 14:32 PDT by Jonathan Bedard
Modified: 2019-07-18 18:34 PDT (History)
8 users (show)

See Also:


Attachments
Patch (645.41 KB, patch)
2019-07-17 15:24 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (645.71 KB, patch)
2019-07-18 16:37 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (645.73 KB, patch)
2019-07-18 17:03 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-07-16 14:32:40 PDT
We have a results-database that we've been using Internally for a few months that we would like begin the process of replacing the flakiness dashboard <https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html> with. The first step in this process is to migrate the bulk of the code supporting this database into WebKit.
Comment 1 Radar WebKit Bug Importer 2019-07-16 14:33:05 PDT
<rdar://problem/53172130>
Comment 2 Jonathan Bedard 2019-07-17 15:24:29 PDT
Created attachment 374338 [details]
Patch
Comment 3 Jonathan Bedard 2019-07-18 16:37:48 PDT
Created attachment 374428 [details]
Patch
Comment 4 Aakash Jain 2019-07-18 16:57:27 PDT
View in context: https://bugs.webkit.org/attachment.cgi?id=374338&action=review

rs=me

> Tools/resultsdbpy/resultsdbpy/controller/configuration.py:58
> +        self.sdk = None if not sdk or sdk == '?' else str(sdk)

I always find multi-line if-else easier to understand and less error-prone. Might be a good idea to convert this to multi-line, something like:

self.sdk = None
if sdk and sdk != '?':
    self.sdk = str(sdk)
Comment 5 Jonathan Bedard 2019-07-18 17:03:25 PDT
Created attachment 374429 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-07-18 18:34:46 PDT
Comment on attachment 374429 [details]
Patch for landing

Clearing flags on attachment: 374429

Committed r247628: <https://trac.webkit.org/changeset/247628>
Comment 7 WebKit Commit Bot 2019-07-18 18:34:48 PDT
All reviewed patches have been landed.  Closing bug.