Bug 199944 - [ews-build] Enable all macOS queues on new EWS
Summary: [ews-build] Enable all macOS queues on new EWS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-19 08:05 PDT by Aakash Jain
Modified: 2019-08-21 11:24 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.51 KB, patch)
2019-07-19 08:11 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Patch for landing (6.59 KB, patch)
2019-07-31 18:06 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-07-19 08:05:57 PDT
Now that we have layout-tests running in new EWS, we can move all the mac queues from old to new EWS.
Comment 1 Aakash Jain 2019-07-19 08:11:26 PDT
Created attachment 374467 [details]
Patch
Comment 2 Jonathan Bedard 2019-07-19 08:32:49 PDT
Are we certain that our iOS layout testing queues are working?

I wonder if it would be better to wait to land this until early next week, so that any large problems with layout tests in new EWS are surfaced before we go all in.
Comment 3 Aakash Jain 2019-07-19 13:18:55 PDT
Sample runs:

macOS-High-Sierra-Release-Build-EWS:
https://ews-build.webkit.org/#/builders/7 (already live on new EWS for a while, was required for API tests)

macOS-High-Sierra-Release-WK1-Tests-EWS:
https://ews-build.webkit-uat.org/#/builders/34/builds/1

macOS-High-Sierra-Release-WK2-Tests-EWS:
https://ews-build.webkit-uat.org/#/builders/35/builds/94

macOS-High-Sierra-Debug-Build-EWS:
https://ews-build.webkit-uat.org/#/builders/36/builds/139

macOS-High-Sierra-Debug-WK1-Tests-EWS:
https://ews-build.webkit-uat.org/#/builders/37/builds/1
Comment 4 Aakash Jain 2019-07-19 13:26:12 PDT
(In reply to Jonathan Bedard from comment #2)
> Are we certain that our iOS layout testing queues are working?
Seems to be working fine in 50+ builds it has performed so far.

> I wonder if it would be better to wait to land this until early next week, so that any large problems with layout tests in new EWS are surfaced before we go all in.
Even after landing, it might take us some time to deploy in production, as the bots needs to be re-imaged.
Comment 5 Jonathan Bedard 2019-07-19 13:33:50 PDT
(In reply to Aakash Jain from comment #4)
> (In reply to Jonathan Bedard from comment #2)
> > Are we certain that our iOS layout testing queues are working?
> Seems to be working fine in 50+ builds it has performed so far.
> 
> > I wonder if it would be better to wait to land this until early next week, so that any large problems with layout tests in new EWS are surfaced before we go all in.
> Even after landing, it might take us some time to deploy in production, as
> the bots needs to be re-imaged.

Discussed this with Aakash on IRC. We don't intend to deploy this until Monday. I think we're in a good spot, but Friday afternoon deployments are usually a bad idea.

I'll r+ it, though. Seems like a good idea to have it landed.
Comment 6 Aakash Jain 2019-07-31 18:06:46 PDT
Created attachment 375275 [details]
Patch for landing
Comment 7 Aakash Jain 2019-07-31 18:17:12 PDT
Committed r248088: <https://trac.webkit.org/changeset/248088>
Comment 8 Radar WebKit Bug Importer 2019-07-31 18:18:19 PDT
<rdar://problem/53790744>
Comment 9 Aakash Jain 2019-08-21 11:24:50 PDT
This change has been deployed to production, and all these macOS queues are now live on new EWS.