Bug 199944 – [ews-build] Enable all macOS queues on new EWS

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

Now that we have layout-tests running in new EWS, we can move all the mac queues from old to new EWS.

[Aakash Jain]

Created attachment 374467 [details]
Patch

[Jonathan Bedard]

Are we certain that our iOS layout testing queues are working?

I wonder if it would be better to wait to land this until early next week, so that any large problems with layout tests in new EWS are surfaced before we go all in.

[Aakash Jain]

Sample runs:

macOS-High-Sierra-Release-Build-EWS:
https://ews-build.webkit.org/#/builders/7 (already live on new EWS for a while, was required for API tests)

macOS-High-Sierra-Release-WK1-Tests-EWS:
https://ews-build.webkit-uat.org/#/builders/34/builds/1

macOS-High-Sierra-Release-WK2-Tests-EWS:
https://ews-build.webkit-uat.org/#/builders/35/builds/94

macOS-High-Sierra-Debug-Build-EWS:
https://ews-build.webkit-uat.org/#/builders/36/builds/139

macOS-High-Sierra-Debug-WK1-Tests-EWS:
https://ews-build.webkit-uat.org/#/builders/37/builds/1

[Aakash Jain]

(In reply to Jonathan Bedard from comment #2)
> Are we certain that our iOS layout testing queues are working?
Seems to be working fine in 50+ builds it has performed so far.

> I wonder if it would be better to wait to land this until early next week, so that any large problems with layout tests in new EWS are surfaced before we go all in.
Even after landing, it might take us some time to deploy in production, as the bots needs to be re-imaged.

[Jonathan Bedard]

(In reply to Aakash Jain from comment #4)
> (In reply to Jonathan Bedard from comment #2)
> > Are we certain that our iOS layout testing queues are working?
> Seems to be working fine in 50+ builds it has performed so far.
> 
> > I wonder if it would be better to wait to land this until early next week, so that any large problems with layout tests in new EWS are surfaced before we go all in.
> Even after landing, it might take us some time to deploy in production, as
> the bots needs to be re-imaged.

Discussed this with Aakash on IRC. We don't intend to deploy this until Monday. I think we're in a good spot, but Friday afternoon deployments are usually a bad idea.

I'll r+ it, though. Seems like a good idea to have it landed.

[Aakash Jain]

Created attachment 375275 [details]
Patch for landing

[Aakash Jain]

Committed r248088: <https://trac.webkit.org/changeset/248088>

[Radar WebKit Bug Importer]

<rdar://problem/53790744>

[Aakash Jain]

This change has been deployed to production, and all these macOS queues are now live on new EWS.