Bug 199867 - [ews-build] Enable iOS WK2 tester queue on new EWS
Summary: [ews-build] Enable iOS WK2 tester queue on new EWS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-17 09:55 PDT by Aakash Jain
Modified: 2019-07-19 08:05 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.36 KB, patch)
2019-07-17 09:59 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
Patch (5.22 KB, patch)
2019-07-18 13:57 PDT, Aakash Jain 		jbedard: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-07-17 09:55:51 PDT 
Enable iOS WK2 (tester) queue on new EWS.
Comment 1 Aakash Jain 2019-07-17 09:59:51 PDT 
Created attachment 374301 [details]
Patch
Comment 2 Jonathan Bedard 2019-07-18 13:39:56 PDT 
Comment on attachment 374301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374301&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:42
> +    ALL_QUEUES = ['ios', 'ios-sim', 'gtk', 'wpe', 'wincairo', 'ios-wk2', 'api-ios', 'api-mac', 'bindings', 'jsc', 'mac', 'mac-32bit', 'mac-32bit-wk2',

Why do we have ios-sim and ios-wk2? Is ios-sim API tests?
Comment 3 Aakash Jain 2019-07-18 13:48:12 PDT 
> Why do we have ios-sim and ios-wk2? Is ios-sim API tests?
'ios-sim' is the builder queue, and 'ios-wk2' is the tester queue. 
https://ews-build.webkit.org/#/builders/13
https://ews-build.webkit.org/#/builders/18

API test is different, 'api-ios'.

We have been running ios-sim builder queue on new EWS for a while, so that it can trigger ios-api. However, we didn't display the 'ios-sim' bubble as old EWS was displaying that bubble (which was for build + test). Now that we will be removing old EWS' 'ios-sim' bubble, we should display both builder and tester bubbles on new EWS.

With this patch, for iOS we will start getting the benefit of building once and testing on multiple queues (WK2, API).
Comment 4 Aakash Jain 2019-07-18 13:57:55 PDT 
Created attachment 374414 [details]
Patch
Comment 5 Aakash Jain 2019-07-18 13:58:35 PDT 
(In reply to Aakash Jain from comment #4)
> Created attachment 374414 [details]
> Patch
Also removing the queue from old EWS in this patch itself.
Comment 6 Aakash Jain 2019-07-18 15:35:51 PDT 
Committed r247622: <https://trac.webkit.org/changeset/247622>
Comment 7 Radar WebKit Bug Importer 2019-07-18 15:36:19 PDT 
<rdar://problem/53276794>