Bug 199794 - Add runtime flag for lazy image loading
Summary: Add runtime flag for lazy image loading
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks: 196698
  Show dependency tree / graph
 
Reported: 2019-07-15 01:27 PDT by Rob Buis
Modified: 2019-09-06 03:01 PDT (History)
12 users (show)

See Also:

Attachments
Patch (16.77 KB, patch)
2019-07-15 01:33 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (17.48 KB, patch)
2019-07-15 02:36 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (17.56 KB, patch)
2019-08-02 03:25 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (21.17 KB, patch)
2019-08-05 01:33 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (21.22 KB, patch)
2019-08-08 05:27 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (13.43 KB, patch)
2019-09-05 23:50 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2019-07-15 01:27:19 PDT 
Add runtime flag for lazy image loading.
Comment 1 Rob Buis 2019-07-15 01:33:46 PDT 
Created attachment 374107 [details]
Patch
Comment 2 Rob Buis 2019-07-15 02:36:46 PDT 
Created attachment 374108 [details]
Patch
Comment 3 Rob Buis 2019-08-02 03:25:57 PDT 
Created attachment 375406 [details]
Patch
Comment 4 Darin Adler 2019-08-04 18:22:18 PDT 
Comment on attachment 375406 [details]
Patch

OK. Wow this sure is a long way from "just add it to a list in one place". The WebKitLegacy part is particularly huge and ugly. Ironic because it’s not used by Safari.

I was going to say review+, but wait, where is the part that makes this work in WebKitTestRunner for modern WebKit?
Comment 5 Rob Buis 2019-08-05 01:33:40 PDT 
Created attachment 375526 [details]
Patch
Comment 6 Rob Buis 2019-08-05 08:29:04 PDT 
(In reply to Darin Adler from comment #4)
> Comment on attachment 375406 [details]
> Patch
> 
> OK. Wow this sure is a long way from "just add it to a list in one place".
> The WebKitLegacy part is particularly huge and ugly. Ironic because it’s not
> used by Safari.

It is a lot of work and easy to miss things. At least having dealt with it in the past, it is a little easier now.

> I was going to say review+, but wait, where is the part that makes this work
> in WebKitTestRunner for modern WebKit?

Good catch, I added the TestOption in WebKitTestRunner.
Comment 7 Rob Buis 2019-08-08 05:27:25 PDT 
Created attachment 375796 [details]
Patch
Comment 8 WebKit Commit Bot 2019-08-08 07:55:27 PDT 
Comment on attachment 375796 [details]
Patch

Clearing flags on attachment: 375796

Committed r248409: <https://trac.webkit.org/changeset/248409>
Comment 9 WebKit Commit Bot 2019-08-08 07:55:29 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-08-08 07:56:18 PDT 
<rdar://problem/54079915>
Comment 11 Rob Buis 2019-09-05 23:50:17 PDT 
Reopening to attach new patch.
Comment 12 Rob Buis 2019-09-05 23:50:19 PDT 
Created attachment 378162 [details]
Patch
Comment 13 WebKit Commit Bot 2019-09-06 03:01:34 PDT 
Comment on attachment 378162 [details]
Patch

Clearing flags on attachment: 378162

Committed r249571: <https://trac.webkit.org/changeset/249571>
Comment 14 WebKit Commit Bot 2019-09-06 03:01:36 PDT 
All reviewed patches have been landed.  Closing bug.