https://github.com/whatwg/html/pull/3752/files https://github.com/scott-little/lazyload
<rdar://problem/49701250>
<rdar://problem/35457900>
Created attachment 367803 [details] Patch
Comment on attachment 367803 [details] Patch Attachment 367803 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11933271 Number of test failures exceeded the failure limit.
Created attachment 367818 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 367803 [details] Patch Attachment 367803 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11937929 Number of test failures exceeded the failure limit.
Created attachment 367871 [details] Archive of layout-test-results from ews113 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 367803 [details] Patch Attachment 367803 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11940816 Number of test failures exceeded the failure limit.
Created attachment 367889 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 367907 [details] Patch
Comment on attachment 367907 [details] Patch Attachment 367907 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11945100 Number of test failures exceeded the failure limit.
Created attachment 367908 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 367909 [details] Patch
Created attachment 367913 [details] Patch
Comment on attachment 367913 [details] Patch Attachment 367913 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11957801 New failing tests: http/tests/lazyload/lazy.html http/tests/lazyload/fixed-dimension.html fast/filter-image/filter-image-svg.html http/tests/lazyload/attribute.html http/tests/images/draw-pattern-slow-load-large-image.html http/tests/lazyload/style-dimension.html
Created attachment 367938 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
EWS bots are hanging after processing this patch. Obsoleting the Patch so bots will stop processing.
(In reply to Shawn Roberts from comment #17) > EWS bots are hanging after processing this patch. > > Obsoleting the Patch so bots will stop processing. Do you think it is due to something in the patch or just random?
(In reply to Rob Buis from comment #18) > (In reply to Shawn Roberts from comment #17) > > EWS bots are hanging after processing this patch. > > > > Obsoleting the Patch so bots will stop processing. > > Do you think it is due to something in the patch or just random? No I don't think this was specific to your patch. This has happened with a few other patches on a few different queues.
Created attachment 368017 [details] Patch
Created attachment 368018 [details] Patch
Created attachment 368020 [details] Patch
Created attachment 368023 [details] Patch
Comment on attachment 368023 [details] Patch Attachment 368023 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11971500 New failing tests: http/tests/lazyload/lazy.html http/tests/lazyload/fixed-dimension.html fast/filter-image/filter-image-svg.html http/tests/lazyload/attribute.html http/tests/images/draw-pattern-slow-load-large-image.html http/tests/lazyload/style-dimension.html
Created attachment 368034 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 368023 [details] Patch Attachment 368023 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11972346 New failing tests: http/tests/lazyload/lazy.html http/tests/preload/single_download_preload_headers.php http/tests/lazyload/fixed-dimension.html http/tests/lazyload/attribute.html fast/filter-image/filter-image-svg.html http/tests/lazyload/style-dimension.html http/tests/preload/single_download_preload.html
Created attachment 368038 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368023 [details] Patch Attachment 368023 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11972424 New failing tests: imported/w3c/web-platform-tests/preload/single-download-preload.html http/tests/lazyload/lazy.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.png.complexcolours.html http/tests/preload/single_download_preload_headers.php imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.jpeg.quality.basic.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.dataURI.html http/tests/lazyload/fixed-dimension.html http/tests/lazyload/attribute.html fast/filter-image/filter-image-svg.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.png.primarycolours.html http/tests/lazyload/style-dimension.html http/tests/preload/single_download_preload.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.jpeg.alpha.html
Created attachment 368042 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 368051 [details] Patch
Comment on attachment 368051 [details] Patch Attachment 368051 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11974565 New failing tests: http/tests/lazyload/lazy.html http/tests/preload/single_download_preload_headers.php http/tests/lazyload/fixed-dimension.html http/tests/lazyload/attribute.html fast/filter-image/filter-image-svg.html http/tests/lazyload/style-dimension.html http/tests/preload/single_download_preload.html
Created attachment 368059 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368051 [details] Patch Attachment 368051 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11974962 New failing tests: imported/w3c/web-platform-tests/preload/single-download-preload.html http/tests/lazyload/lazy.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.png.complexcolours.html http/tests/preload/single_download_preload_headers.php imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.jpeg.quality.basic.html http/tests/lazyload/fixed-dimension.html http/tests/lazyload/attribute.html fast/filter-image/filter-image-svg.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.png.primarycolours.html http/tests/lazyload/style-dimension.html http/tests/preload/single_download_preload.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.jpeg.alpha.html
Created attachment 368067 [details] Archive of layout-test-results from ews114 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368051 [details] Patch Attachment 368051 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11976043 New failing tests: http/tests/lazyload/lazy.html http/tests/lazyload/fixed-dimension.html fast/filter-image/filter-image-svg.html http/tests/lazyload/attribute.html http/tests/images/draw-pattern-slow-load-large-image.html http/tests/lazyload/style-dimension.html
Created attachment 368084 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 368051 [details] Patch Attachment 368051 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11978026 Number of test failures exceeded the failure limit.
Created attachment 368103 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 368051 [details] Patch Attachment 368051 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11978590 Number of test failures exceeded the failure limit.
Created attachment 368109 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 368239 [details] Patch
Comment on attachment 368239 [details] Patch Attachment 368239 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11995739 New failing tests: http/tests/lazyload/lazy.html http/tests/lazyload/style-dimension.html http/tests/lazyload/fixed-dimension.html fast/filter-image/filter-image-svg.html http/tests/lazyload/attribute.html
Created attachment 368244 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368239 [details] Patch Attachment 368239 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11995761 New failing tests: http/tests/lazyload/attribute.html fast/filter-image/filter-image-svg.html
Created attachment 368248 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 368239 [details] Patch Attachment 368239 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11995823 New failing tests: http/tests/lazyload/lazy.html http/tests/lazyload/style-dimension.html http/tests/lazyload/fixed-dimension.html fast/filter-image/filter-image-svg.html http/tests/lazyload/attribute.html
Created attachment 368250 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368239 [details] Patch Attachment 368239 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11995929 New failing tests: http/tests/lazyload/lazy.html http/tests/lazyload/style-dimension.html http/tests/lazyload/fixed-dimension.html fast/filter-image/filter-image-svg.html http/tests/lazyload/attribute.html
Created attachment 368252 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment on attachment 368239 [details] Patch Attachment 368239 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11997383 New failing tests: http/tests/lazyload/attribute.html fast/filter-image/filter-image-svg.html
Created attachment 368270 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 368394 [details] Patch
Comment on attachment 368394 [details] Patch Attachment 368394 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12014708 Number of test failures exceeded the failure limit.
Created attachment 368396 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 368394 [details] Patch Attachment 368394 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12014721 Number of test failures exceeded the failure limit.
Created attachment 368397 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368394 [details] Patch Attachment 368394 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12014689 Number of test failures exceeded the failure limit.
Created attachment 368398 [details] Archive of layout-test-results from ews113 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368394 [details] Patch Attachment 368394 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12014742 Number of test failures exceeded the failure limit.
Created attachment 368399 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4
Created attachment 368651 [details] Patch
Comment on attachment 368651 [details] Patch Attachment 368651 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12049500 New failing tests: http/tests/lazyload/lazy.html http/tests/lazyload/style-dimension.html http/tests/lazyload/fixed-dimension.html fast/filter-image/filter-image-svg.html http/tests/lazyload/attribute.html
Created attachment 368652 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368651 [details] Patch Attachment 368651 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12049534 New failing tests: fast/filter-image/filter-image-svg.html
Created attachment 368653 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 368651 [details] Patch Attachment 368651 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12049555 New failing tests: http/tests/lazyload/lazy.html http/tests/lazyload/style-dimension.html http/tests/lazyload/fixed-dimension.html fast/filter-image/filter-image-svg.html http/tests/lazyload/attribute.html
Created attachment 368654 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368651 [details] Patch Attachment 368651 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12049577 New failing tests: fast/filter-image/filter-image-svg.html
Created attachment 368656 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4
Created attachment 368657 [details] Patch
Comment on attachment 368657 [details] Patch Attachment 368657 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12050478 New failing tests: imported/w3c/web-platform-tests/loading/lazyload/scroll_to_attribute_on_image.tentative.html
Created attachment 368659 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368657 [details] Patch Attachment 368657 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12050509 New failing tests: imported/w3c/web-platform-tests/loading/lazyload/scroll_to_attribute_on_image.tentative.html
Created attachment 368661 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 368657 [details] Patch Attachment 368657 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12050531 New failing tests: http/tests/lazyload/attribute.html
Created attachment 368663 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4
Comment on attachment 368657 [details] Patch Attachment 368657 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12050574 New failing tests: http/tests/lazyload/fixed-dimension.html http/tests/lazyload/attribute.html http/tests/lazyload/style-dimension.html
Created attachment 368665 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Created attachment 368666 [details] Patch
This patch should be green now, or close. It is based on chromium's implementation, with the exception that for loading=auto or unspecified this patch will keep old loading behavior (eager) since otherwise too many tests would break. The patch is not really for review right now as the spec is still evolving and the patch is too big. I am thinking of splitting it up like this: - Import WPT lazy image loading tests (should be submitted to WPT first). - Add runtime flag and DRT/test runner glue code. - Implementation of core lazy image loading. - CSS Background image support. - IFrame lazy loading (not started yet). I guess this means adding sub issues to this bug.
Comment on attachment 368666 [details] Patch Attachment 368666 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12051450 New failing tests: http/tests/lazyload/attribute.html
Created attachment 368673 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Created attachment 371939 [details] Patch
Comment on attachment 371939 [details] Patch Attachment 371939 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12453002 New failing tests: http/tests/lazyload/attribute.html
Created attachment 371941 [details] Archive of layout-test-results from ews214 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 371951 [details] Patch
Attachment 371951 [details] did not pass style-queue: ERROR: Source/WebCore/loader/ImageLoader.cpp:189: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 88 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 371967 [details] Patch
Attachment 371967 [details] did not pass style-queue: ERROR: Source/WebCore/loader/ImageLoader.cpp:189: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 88 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 371967 [details] Patch Attachment 371967 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12455919 New failing tests: fast/events/mouse-focus-imagemap.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_empty.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_specified.html imported/w3c/web-platform-tests/content-security-policy/unsafe-hashes/style_attribute_allowed.html fast/dom/beforeload/cached-image-before-load.html http/tests/lazyload/fixed-dimension.html accessibility/text-marker/character-offset-visible-position-conversion-hang.html fast/hidpi/image-srcset-simple-in-variable-2x.html http/tests/lazyload/attribute.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_unspecified.html http/tests/security/load-image-after-redirection-2.html http/tests/lazyload/style-dimension.html fast/dom/HTMLAnchorElement/anchor-ismap-crash.html fast/images/animated-gif-webkit-transform.html css3/filters/should-not-have-compositing-layer.html http/tests/security/load-image-after-redirection.html fast/css-grid-layout/grid-align-baseline.html
Created attachment 371972 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 371967 [details] Patch Attachment 371967 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/12455973 New failing tests: http/tests/lazyload/lazy.html http/tests/security/load-image-after-redirection-2.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_empty.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_specified.html imported/w3c/web-platform-tests/content-security-policy/unsafe-hashes/style_attribute_allowed.html fast/events/mouse-focus-imagemap.html http/tests/lazyload/fixed-dimension.html http/tests/lazyload/attribute.html fast/hidpi/image-srcset-simple-in-variable-2x.html accessibility/text-marker/character-offset-visible-position-conversion-hang.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_unspecified.html http/tests/lazyload/style-dimension.html fast/images/animated-gif-scrolling-crash.html fast/images/animated-gif-webkit-transform.html css3/filters/should-not-have-compositing-layer.html fast/dom/beforeload/cached-image-before-load.html http/tests/security/load-image-after-redirection.html fast/css-grid-layout/grid-align-baseline.html
Created attachment 371974 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 371967 [details] Patch Attachment 371967 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12456135 New failing tests: fast/events/mouse-focus-imagemap.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_empty.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_specified.html imported/w3c/web-platform-tests/content-security-policy/unsafe-hashes/style_attribute_allowed.html fast/dom/beforeload/cached-image-before-load.html http/tests/lazyload/fixed-dimension.html accessibility/text-marker/character-offset-visible-position-conversion-hang.html fast/hidpi/image-srcset-simple-in-variable-2x.html http/tests/lazyload/attribute.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_unspecified.html http/tests/security/load-image-after-redirection-2.html http/tests/lazyload/style-dimension.html fast/images/animated-gif-webkit-transform.html css3/filters/should-not-have-compositing-layer.html http/tests/security/load-image-after-redirection.html fast/css-grid-layout/grid-align-baseline.html
Created attachment 371978 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 371967 [details] Patch Attachment 371967 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12456098 New failing tests: http/tests/lazyload/lazy.html http/tests/security/load-image-after-redirection-2.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_empty.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_specified.html imported/w3c/web-platform-tests/content-security-policy/unsafe-hashes/style_attribute_allowed.html http/tests/lazyload/fixed-dimension.html fast/dom/beforeload/cached-image-before-load.html http/tests/webgl/1.0.2/origin-clean-conformance.html accessibility/text-marker/character-offset-visible-position-conversion-hang.html fast/hidpi/image-srcset-simple-in-variable-2x.html imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_unspecified.html http/tests/lazyload/style-dimension.html fast/images/animated-gif-scrolling-crash.html css3/filters/should-not-have-compositing-layer.html http/tests/security/load-image-after-redirection.html
Created attachment 371979 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Comment on attachment 371967 [details] Patch Attachment 371967 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12456468 New failing tests: http/tests/security/load-image-after-redirection-2.html fast/events/mouse-focus-imagemap.html fast/dom/beforeload/cached-image-before-load.html http/tests/lazyload/fixed-dimension.html http/tests/lazyload/attribute.html http/tests/lazyload/style-dimension.html fast/dom/HTMLAnchorElement/anchor-ismap-crash.html css3/filters/should-not-have-compositing-layer.html http/tests/security/load-image-after-redirection.html
Created attachment 371980 [details] Archive of layout-test-results from ews214 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 372030 [details] Patch
Created attachment 372041 [details] Patch
Comment on attachment 372041 [details] Patch Attachment 372041 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12463952 New failing tests: http/tests/lazyload/attribute.html
Created attachment 372050 [details] Archive of layout-test-results from ews211 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews211 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Created attachment 376011 [details] Patch
Created attachment 376015 [details] Patch
Created attachment 376033 [details] Patch
Comment on attachment 376033 [details] Patch Attachment 376033 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12893740 New failing tests: imported/w3c/web-platform-tests/loading/lazyload/scroll_to_attribute_invalid_image.tentative.html imported/w3c/web-platform-tests/loading/lazyload/scroll_to_attribute_auto_image.tentative.html http/tests/lazyload/fixed-dimension.html imported/w3c/web-platform-tests/loading/lazyload/scroll_to_attribute_unset_image.tentative.html imported/w3c/web-platform-tests/loading/lazyload/attribute_off_image.tentative.html imported/w3c/web-platform-tests/loading/lazyload/window_load_event_occurs_with_below_viewport_image.tentative.html imported/w3c/web-platform-tests/loading/lazyload/change_attribute_to_off_image.tentative.html
Created attachment 376034 [details] Archive of layout-test-results from ews103 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 376033 [details] Patch Attachment 376033 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12893769 New failing tests: imported/w3c/web-platform-tests/loading/lazyload/scroll_to_attribute_invalid_image.tentative.html imported/w3c/web-platform-tests/loading/lazyload/scroll_to_attribute_auto_image.tentative.html http/tests/lazyload/fixed-dimension.html imported/w3c/web-platform-tests/loading/lazyload/scroll_to_attribute_unset_image.tentative.html imported/w3c/web-platform-tests/loading/lazyload/attribute_off_image.tentative.html imported/w3c/web-platform-tests/loading/lazyload/window_load_event_occurs_with_below_viewport_image.tentative.html imported/w3c/web-platform-tests/loading/lazyload/change_attribute_to_off_image.tentative.html
Created attachment 376035 [details] Archive of layout-test-results from ews114 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 376036 [details] Patch
Comment on attachment 376036 [details] Patch Attachment 376036 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12894196 New failing tests: http/tests/lazyload/fixed-dimension.html
Created attachment 376039 [details] Archive of layout-test-results from ews100 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 376036 [details] Patch Attachment 376036 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12894207 New failing tests: http/tests/lazyload/fixed-dimension.html
Created attachment 376040 [details] Archive of layout-test-results from ews115 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 376158 [details] Patch
Created attachment 376167 [details] Patch
Comment on attachment 376167 [details] Patch Attachment 376167 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/12904837 New failing tests: imported/w3c/web-platform-tests/loading/lazyload/image-loading-lazy.tentative.html
Created attachment 376176 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 376167 [details] Patch Attachment 376167 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/12904894 New failing tests: imported/w3c/web-platform-tests/loading/lazyload/image-loading-lazy.tentative.html
Created attachment 376180 [details] Archive of layout-test-results from ews117 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 376246 [details] Patch
Created attachment 376259 [details] Patch
The according Firefox issue just was marked as resolved. Support for the "loading" attribute will ship with Firefox 75: https://bugzilla.mozilla.org/show_bug.cgi?id=1542784 Safari is the only major browser lacking this feature...
Gute morgen, (In reply to m.kurz+webkitbugs from comment #124) > The according Firefox issue just was marked as resolved. Support for the > "loading" attribute will ship with Firefox 75: > https://bugzilla.mozilla.org/show_bug.cgi?id=1542784 > > Safari is the only major browser lacking this feature... I was waiting for the spec to land before working again on this. First step is to fix the tests: https://github.com/web-platform-tests/wpt/pull/21773 I'll incorporate them into https://bugs.webkit.org/show_bug.cgi?id=200764, test a bit and hopefully put it up for review soon.
Spec has landed just FYI
(In reply to Dominic Farolino from comment #126) > Spec has landed just FYI I was aware of this :) BTW any news on lazy iframe loading being specified?
Yep, I just said it has landed.
(In reply to Dominic Farolino from comment #128) > Yep, I just said it has landed. Ah, sorry, I thought you were referring to https://github.com/whatwg/html/pull/5510 for some reason. That is great news!
Looks like this can be closed since both are implemented.
Both? Lazy iframe loading is implemented?
(In reply to Simon Fraser (smfr) from comment #131) > Both? Lazy iframe loading is implemented? I think so, that was https://bugs.webkit.org/show_bug.cgi?id=215442.
It seems like iframe lazy loading is still disabled by default (https://bugs.webkit.org/show_bug.cgi?id=215566). Is there a bug to enable iframe lazy loading?