Bug 199552 - Web Inspector: DOM Debugger: there should be different icons for each type of DOM breakpoint
Summary: Web Inspector: DOM Debugger: there should be different icons for each type of...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-06 12:10 PDT by Devin Rousso
Modified: 2019-07-08 20:17 PDT (History)
5 users (show)

See Also:

Attachments
Patch (13.31 KB, patch)
2019-07-06 12:26 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (90.79 KB, image/png)
2019-07-06 12:27 PDT, Devin Rousso 		no flags Details
Patch (13.71 KB, patch)
2019-07-06 12:33 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-07-06 12:10:38 PDT 
Using the "source" icon [=] is weird, especially since all other breakpoint types have an icon.  I'd imagine that it would be something like a [S] (for Subtree Modified), [A] (for Attribute Modified), or [R] (for Node Removed).
Comment 1 Devin Rousso 2019-07-06 12:26:04 PDT 
Created attachment 373571 [details]
Patch
Comment 2 Devin Rousso 2019-07-06 12:27:38 PDT 
Created attachment 373572 [details]
[Image] After Patch is applied
Comment 3 Devin Rousso 2019-07-06 12:33:56 PDT 
Created attachment 373574 [details]
Patch
Comment 4 Joseph Pecoraro 2019-07-08 20:02:36 PDT 
Comment on attachment 373574 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373574&action=review

r=me

> Source/WebInspectorUI/UserInterface/Images/DOMBreakpointSubtreeModified.svg:6
> +    <path fill="rgb(113, 146, 184)" d="M 5.19849793 12.6584609 C 5.2831472 12.676395 6.98277851 12.9487305 7.62939453 12.9487305 C 8.79640591 12.9487305 9.76331344 12.6806542 10.5034462 12.1146703 C 11.3037555 11.5026691 11.7177734 10.6286312 11.7177734 9.58544922 C 11.7177734 8.84534902 11.4998181 8.18341061 11.0628295 7.63852362 C 10.6767371 7.15709971 10.0557113 6.69185669 9.18734192 6.20492057 L 8.61524891 5.88648574 C 8.27558142 5.69523066 8.15431716 5.69238281 8.23632812 5.69238281 C 8.56703836 5.69238281 9.10333246 5.81936052 9.8138795 6.08542439 L 11.1645508 6.59118236 L 11.1645508 5.14892578 L 11.1645508 3.87597656 L 11.1645508 3.07965768 L 10.3884483 2.90136387 C 9.52406853 2.70279014 8.73593121 2.60205078 8.02148438 2.60205078 C 7.01081351 2.60205078 6.14909735 2.87110984 5.47554965 3.42697448 C 4.76046595 4.01711791 4.38964844 4.82767811 4.38964844 5.77734375 C 4.38964844 6.49239045 4.61205052 7.14196725 5.04920932 7.68841575 C 5.43639142 8.17239338 6.03437082 8.62885808 6.84888633 9.08727887 L 7.38545082 9.38538774 C 7.71699471 9.57330366 7.92926232 9.72631865 7.99164827 9.79813503 C 7.94460492 9.81851991 7.82252674 9.85302734 7.60253906 9.85302734 C 7.14294036 9.85302734 6.53493744 9.70437137 5.79174704 9.39341305 L 4.40576172 8.81350287 L 4.40576172 10.315918 L 4.40576172 11.6801758 L 4.40576172 12.4905083 L 5.19849793 12.6584609 C 5.52713094 12.7280865 5.52713094 12.7280865 5.57407851 12.738033 L 5.19849793 12.6584609 Z M 5.19849793 12.6584609"/>

We should really consider reducing the significant figures. This is a 16x16 (32x32 on @2x) icon.
Comment 5 Devin Rousso 2019-07-08 20:12:11 PDT 
Comment on attachment 373574 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373574&action=review

>> Source/WebInspectorUI/UserInterface/Images/DOMBreakpointSubtreeModified.svg:6
>> +    <path fill="rgb(113, 146, 184)" d="M 5.19849793 12.6584609 C 5.2831472 12.676395 6.98277851 12.9487305 7.62939453 12.9487305 C 8.79640591 12.9487305 9.76331344 12.6806542 10.5034462 12.1146703 C 11.3037555 11.5026691 11.7177734 10.6286312 11.7177734 9.58544922 C 11.7177734 8.84534902 11.4998181 8.18341061 11.0628295 7.63852362 C 10.6767371 7.15709971 10.0557113 6.69185669 9.18734192 6.20492057 L 8.61524891 5.88648574 C 8.27558142 5.69523066 8.15431716 5.69238281 8.23632812 5.69238281 C 8.56703836 5.69238281 9.10333246 5.81936052 9.8138795 6.08542439 L 11.1645508 6.59118236 L 11.1645508 5.14892578 L 11.1645508 3.87597656 L 11.1645508 3.07965768 L 10.3884483 2.90136387 C 9.52406853 2.70279014 8.73593121 2.60205078 8.02148438 2.60205078 C 7.01081351 2.60205078 6.14909735 2.87110984 5.47554965 3.42697448 C 4.76046595 4.01711791 4.38964844 4.82767811 4.38964844 5.77734375 C 4.38964844 6.49239045 4.61205052 7.14196725 5.04920932 7.68841575 C 5.43639142 8.17239338 6.03437082 8.62885808 6.84888633 9.08727887 L 7.38545082 9.38538774 C 7.71699471 9.57330366 7.92926232 9.72631865 7.99164827 9.79813503 C 7.94460492 9.81851991 7.82252674 9.85302734 7.60253906 9.85302734 C 7.14294036 9.85302734 6.53493744 9.70437137 5.79174704 9.39341305 L 4.40576172 8.81350287 L 4.40576172 10.315918 L 4.40576172 11.6801758 L 4.40576172 12.4905083 L 5.19849793 12.6584609 C 5.52713094 12.7280865 5.52713094 12.7280865 5.57407851 12.738033 L 5.19849793 12.6584609 Z M 5.19849793 12.6584609"/>
> 
> We should really consider reducing the significant figures. This is a 16x16 (32x32 on @2x) icon.

I think that should be a followup, as these icons are copied from existing images with the colors changed.  I'd rather fix them all at once.

<https://webkit.org/b/199607> Web Inspector: simplify SVG images that have lots of decimal points in paths
Comment 6 WebKit Commit Bot 2019-07-08 20:16:10 PDT 
Comment on attachment 373574 [details]
Patch

Clearing flags on attachment: 373574

Committed r247252: <https://trac.webkit.org/changeset/247252>
Comment 7 WebKit Commit Bot 2019-07-08 20:16:11 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-07-08 20:17:22 PDT 
<rdar://problem/52812481>