Bug 199550 - Web Inspector: Debugger: there should be a different icon for URL breakpoints
Summary: Web Inspector: Debugger: there should be a different icon for URL breakpoints
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-06 11:18 PDT by Devin Rousso
Modified: 2019-07-08 16:50 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.22 KB, patch)
2019-07-06 12:36 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (89.81 KB, image/png)
2019-07-06 12:37 PDT, Devin Rousso 		no flags Details
Patch (7.27 KB, patch)
2019-07-08 15:15 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (801.28 KB, image/png)
2019-07-08 15:18 PDT, Devin Rousso 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-07-06 11:18:10 PDT 
Using the "source" icon [=] is weird, especially since all other breakpoint types have an icon.  I'd imagine that it would be something like a [U] (for URL) or [C] (for containing) and [M] (for matching).
Comment 1 Devin Rousso 2019-07-06 12:36:52 PDT 
Created attachment 373575 [details]
Patch
Comment 2 Devin Rousso 2019-07-06 12:37:05 PDT 
Created attachment 373576 [details]
[Image] After Patch is applied
Comment 3 Devin Rousso 2019-07-08 15:15:41 PDT 
Created attachment 373669 [details]
Patch

Extend the "tails" of the arrows to the edge of the box.
Comment 4 Devin Rousso 2019-07-08 15:18:59 PDT 
Created attachment 373671 [details]
[Image] After Patch is applied
Comment 5 Joseph Pecoraro 2019-07-08 15:25:22 PDT 
Comment on attachment 373669 [details]
Patch

Looks good! r=me
Comment 6 WebKit Commit Bot 2019-07-08 16:49:17 PDT 
Comment on attachment 373669 [details]
Patch

Clearing flags on attachment: 373669

Committed r247237: <https://trac.webkit.org/changeset/247237>
Comment 7 WebKit Commit Bot 2019-07-08 16:49:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-07-08 16:50:24 PDT 
<rdar://problem/52804997>