Bug 199543 – [Pointer Events] Use a gesture recognizer to prevent pinch-to-zoom behavior

• Status: RESOLVED
• Resolution: FIXED
• Component: UI Events

[Antoine Quint]

[Pointer Events] Use a gesture recognizer to prevent pinch-to-zoom behavior

[Antoine Quint]

Created attachment 373566 [details]
Patch

[Antoine Quint]

Created attachment 373568 [details]
Patch

[Dean Jackson]

Comment on attachment 373568 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373568&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:146
> +#import "ScrollingTreeScrollingNodeDelegateIOS.h"

Why did you need to add this?

[Antoine Quint]

(In reply to Dean Jackson from comment #3)
> Comment on attachment 373568 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=373568&action=review
> 
> > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:146
> > +#import "ScrollingTreeScrollingNodeDelegateIOS.h"
> 
> Why did you need to add this?

I didn't, this was for a later patch and I forgot to remove it.

[Antoine Quint]

Created attachment 373582 [details]
Patch

[EWS Watchlist]

Comment on attachment 373582 [details]
Patch

Attachment 373582 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12677986

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 373586 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5

[Antoine Quint]

Committed r247197: <https://trac.webkit.org/changeset/247197>

[Radar WebKit Bug Importer]

<rdar://problem/52740554>

[Antoine Quint]

Working on addressing the new timeouts on iOS Simulator, should have a fix up in the next few hours.

[Antoine Quint]

(In reply to Antoine Quint from comment #10)
> Working on addressing the new timeouts on iOS Simulator, should have a fix
> up in the next few hours.

I think I know what the problem is, we should really have ENABLE_POINTER_EVENTS and HAVE_UI_WEB_TOUCH_EVENTS_GESTURE_RECOGNIZER_WITH_ACTIVE_TOUCHES_BY_ID be one and a single thing on iOS since we can't have pointercancel events or the touch-action CSS property implemented without that new API. Running tests locally to see if that indeed fixes everything, but this will take a few hours since mucking with Platform.h causes a complete rebuild.

[Antoine Quint]

I have a patch up at https://bugs.webkit.org/show_bug.cgi?id=199562 to enable PE on iOS 13 and up only for iOS.

[Antoine Quint]

Should be all clear as of r247205.