[Pointer Events] Use a gesture recognizer to prevent pinch-to-zoom behavior
Created attachment 373566 [details] Patch
Created attachment 373568 [details] Patch
Comment on attachment 373568 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=373568&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:146 > +#import "ScrollingTreeScrollingNodeDelegateIOS.h" Why did you need to add this?
(In reply to Dean Jackson from comment #3) > Comment on attachment 373568 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=373568&action=review > > > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:146 > > +#import "ScrollingTreeScrollingNodeDelegateIOS.h" > > Why did you need to add this? I didn't, this was for a later patch and I forgot to remove it.
Created attachment 373582 [details] Patch
Comment on attachment 373582 [details] Patch Attachment 373582 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12677986 Number of test failures exceeded the failure limit.
Created attachment 373586 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.5
Committed r247197: <https://trac.webkit.org/changeset/247197>
<rdar://problem/52740554>
Working on addressing the new timeouts on iOS Simulator, should have a fix up in the next few hours.
(In reply to Antoine Quint from comment #10) > Working on addressing the new timeouts on iOS Simulator, should have a fix > up in the next few hours. I think I know what the problem is, we should really have ENABLE_POINTER_EVENTS and HAVE_UI_WEB_TOUCH_EVENTS_GESTURE_RECOGNIZER_WITH_ACTIVE_TOUCHES_BY_ID be one and a single thing on iOS since we can't have pointercancel events or the touch-action CSS property implemented without that new API. Running tests locally to see if that indeed fixes everything, but this will take a few hours since mucking with Platform.h causes a complete rebuild.
I have a patch up at https://bugs.webkit.org/show_bug.cgi?id=199562 to enable PE on iOS 13 and up only for iOS.
Should be all clear as of r247205.