Bug 199562 - [Pointer Events] Enable only on the most recent version of the supported iOS family
Summary: [Pointer Events] Enable only on the most recent version of the supported iOS ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-07 12:12 PDT by Antoine Quint
Modified: 2019-09-26 02:41 PDT (History)
13 users (show)

See Also:


Attachments
Patch (17.47 KB, patch)
2019-07-07 12:15 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (18.00 KB, patch)
2019-07-07 13:19 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (17.94 KB, patch)
2019-07-07 13:28 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (18.72 KB, patch)
2019-07-07 13:52 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (15.86 KB, patch)
2019-07-07 14:12 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (15.67 KB, patch)
2019-07-07 14:47 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (18.93 KB, patch)
2019-07-08 00:59 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (18.93 KB, patch)
2019-07-08 01:56 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2019-07-07 12:12:21 PDT
[Pointer Events] Enable only on the most recent version of the supported iOS family
Comment 1 Antoine Quint 2019-07-07 12:15:14 PDT
Created attachment 373598 [details]
Patch
Comment 2 EWS Watchlist 2019-07-07 12:18:15 PDT
Attachment 373598 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dean Jackson 2019-07-07 12:52:24 PDT
Comment on attachment 373598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373598&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

OOPS!
Comment 4 Antoine Quint 2019-07-07 13:19:53 PDT
Created attachment 373599 [details]
Patch
Comment 5 EWS Watchlist 2019-07-07 13:22:41 PDT
Attachment 373599 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:9:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Antoine Quint 2019-07-07 13:28:04 PDT
Created attachment 373600 [details]
Patch
Comment 7 Antoine Quint 2019-07-07 13:52:21 PDT
Created attachment 373601 [details]
Patch
Comment 8 Antoine Quint 2019-07-07 14:12:44 PDT
Created attachment 373603 [details]
Patch
Comment 9 Antoine Quint 2019-07-07 14:47:47 PDT
Created attachment 373604 [details]
Patch
Comment 10 Radar WebKit Bug Importer 2019-07-08 00:52:23 PDT
<rdar://problem/52766511>
Comment 11 Antoine Quint 2019-07-08 00:59:34 PDT
Created attachment 373618 [details]
Patch
Comment 12 Antoine Quint 2019-07-08 01:56:38 PDT
Created attachment 373619 [details]
Patch
Comment 13 Antoine Quint 2019-07-08 04:22:15 PDT
Committed r247205: <https://trac.webkit.org/changeset/247205>
Comment 14 Frédéric Wang (:fredw) 2019-09-26 02:41:36 PDT
Comment on attachment 373619 [details]
Patch

cancelling review, IIUC it's already landed