Bug 199428 - [Win] test-webkitpy is failing in _supports_building_and_running_lldb_tests: AttributeError: 'NoneType' object has no attribute 'startswith'
Summary: [Win] test-webkitpy is failing in _supports_building_and_running_lldb_tests: ...
Status: RESOLVED DUPLICATE of bug 199493
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-02 19:15 PDT by Fujii Hironori
Modified: 2019-07-04 07:02 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.41 KB, patch)
2019-07-02 19:25 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-07-02 19:15:44 PDT
[Win] test-webkitpy is failing in _supports_building_and_running_lldb_tests: AttributeError: 'NoneType' object has no attribute 'startswith'

AppleWin and WinCairo are failing.

https://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/2856
https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Tests%29/builds/4417

> Traceback (most recent call last):
>   File "/home/buildbot/worker/win7-release-tests/build/Tools/Scripts/webkitpy/test/main.py", line 374, in <module>
>     sys.exit(main())
>   File "/home/buildbot/worker/win7-release-tests/build/Tools/Scripts/webkitpy/test/main.py", line 72, in main
>     if not _supports_building_and_running_lldb_tests():
>   File "/home/buildbot/worker/win7-release-tests/build/Tools/Scripts/webkitpy/test/main.py", line 107, in _supports_building_and_running_lldb_tests
>     return not _host.platform.build_version().startswith('19A')
> AttributeError: 'NoneType' object has no attribute 'startswith'

Since Bug 199078.
Comment 1 Fujii Hironori 2019-07-02 19:25:59 PDT
Created attachment 373377 [details]
Patch
Comment 2 Jonathan Bedard 2019-07-03 07:17:00 PDT
Comment on attachment 373377 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373377&action=review

> Tools/Scripts/webkitpy/test/main.py:106
> +        return False

Does this work if it's 'True'? I suspect that the issue is the build version check, not the running of the lldb tests, right?
Comment 3 Fujii Hironori 2019-07-03 18:51:27 PDT
Comment on attachment 373377 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373377&action=review

>> Tools/Scripts/webkitpy/test/main.py:106
>> +        return False
> 
> Does this work if it's 'True'? I suspect that the issue is the build version check, not the running of the lldb tests, right?

Yup. build_version is available only for mac.
https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py?rev=243030#L150
Comment 4 Fujii Hironori 2019-07-04 07:01:38 PDT

*** This bug has been marked as a duplicate of bug 199493 ***