Bug 199428 – [Win] test-webkitpy is failing in _supports_building_and_running_lldb_tests: AttributeError: 'NoneType' object has no attribute 'startswith'

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Tools / Tests

[Fujii Hironori]

[Win] test-webkitpy is failing in _supports_building_and_running_lldb_tests: AttributeError: 'NoneType' object has no attribute 'startswith'

AppleWin and WinCairo are failing.

https://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/2856
https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Tests%29/builds/4417

> Traceback (most recent call last):
>   File "/home/buildbot/worker/win7-release-tests/build/Tools/Scripts/webkitpy/test/main.py", line 374, in <module>
>     sys.exit(main())
>   File "/home/buildbot/worker/win7-release-tests/build/Tools/Scripts/webkitpy/test/main.py", line 72, in main
>     if not _supports_building_and_running_lldb_tests():
>   File "/home/buildbot/worker/win7-release-tests/build/Tools/Scripts/webkitpy/test/main.py", line 107, in _supports_building_and_running_lldb_tests
>     return not _host.platform.build_version().startswith('19A')
> AttributeError: 'NoneType' object has no attribute 'startswith'

Since Bug 199078.

[Fujii Hironori]

Created attachment 373377 [details]
Patch

[Jonathan Bedard]

Comment on attachment 373377 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373377&action=review

> Tools/Scripts/webkitpy/test/main.py:106
> +        return False

Does this work if it's 'True'? I suspect that the issue is the build version check, not the running of the lldb tests, right?

[Fujii Hironori]

Comment on attachment 373377 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373377&action=review

>> Tools/Scripts/webkitpy/test/main.py:106
>> +        return False
> 
> Does this work if it's 'True'? I suspect that the issue is the build version check, not the running of the lldb tests, right?

Yup. build_version is available only for mac.
https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py?rev=243030#L150

[Fujii Hironori]

*** This bug has been marked as a duplicate of bug 199493 ***