Bug 199078 - test-webkitpy is broken on macOS Catalina
Summary: test-webkitpy is broken on macOS Catalina
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Johnson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-20 13:48 PDT by Dean Johnson
Modified: 2019-07-02 19:17 PDT (History)
10 users (show)

See Also:


Attachments
Patch (2.71 KB, patch)
2019-06-20 14:04 PDT, Dean Johnson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Johnson 2019-06-20 13:48:34 PDT
Building for lldb webkitpy tests fails.
Comment 1 Dean Johnson 2019-06-20 14:04:01 PDT
Created attachment 372581 [details]
Patch
Comment 2 ews-feeder 2019-06-20 15:25:12 PDT
Comment on attachment 372581 [details]
Patch

Rejecting attachment 372581 [details] from commit-queue.

dean_johnson@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 3 Dean Johnson 2019-06-20 15:27:15 PDT
<rdar://problem/51853557>
Comment 4 WebKit Commit Bot 2019-06-20 16:13:06 PDT
Comment on attachment 372581 [details]
Patch

Clearing flags on attachment: 372581

Committed r246662: <https://trac.webkit.org/changeset/246662>
Comment 5 WebKit Commit Bot 2019-06-20 16:13:07 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-06-20 16:14:17 PDT
<rdar://problem/51964923>
Comment 7 Fujii Hironori 2019-07-02 19:17:16 PDT
Windows port are failing.
Filed:  Bug 199428 – [Win] test-webkitpy is failing in _supports_building_and_running_lldb_tests: AttributeError: 'NoneType' object has no attribute 'startswith'