Bug 199405 - [ews-build] Do not print worker environment variables in each build step [part 2]
Summary: [ews-build] Do not print worker environment variables in each build step [par...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-07-02 08:26 PDT by Aakash Jain
Modified: 2019-10-08 10:52 PDT (History)
7 users (show)

See Also:


Attachments
Patch (12.59 KB, patch)
2019-07-02 08:29 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-07-02 08:26:44 PDT
By default Buildbot prints worker's environment variables in each build step. This is unnecessary and makes the logs hard to read. We should disable printing environment variable in most of the build steps.

This is part 2 of https://bugs.webkit.org/show_bug.cgi?id=197319
Comment 1 Aakash Jain 2019-07-02 08:29:10 PDT
Created attachment 373323 [details]
Patch
Comment 2 EWS Watchlist 2019-07-02 08:30:24 PDT Comment hidden (obsolete)
Comment 3 Jonathan Bedard 2019-07-02 11:41:28 PDT
Do we have an example of different logs? Seems like a good idea, I'd just like to see the difference.
Comment 5 WebKit Commit Bot 2019-07-02 12:51:56 PDT
Comment on attachment 373323 [details]
Patch

Clearing flags on attachment: 373323

Committed r247069: <https://trac.webkit.org/changeset/247069>
Comment 6 WebKit Commit Bot 2019-07-02 12:51:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-07-02 12:52:18 PDT
<rdar://problem/52540408>