Bug 199405 – [ews-build] Do not print worker environment variables in each build step [part 2]

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

By default Buildbot prints worker's environment variables in each build step. This is unnecessary and makes the logs hard to read. We should disable printing environment variable in most of the build steps.

This is part 2 of https://bugs.webkit.org/show_bug.cgi?id=197319

[Aakash Jain]

Created attachment 373323 [details]
Patch

[EWS Watchlist]

Attachment 373323 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:117:  [CheckOutSpecificRevision.__init__] Use of super on an old style class  [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:139:  [CleanWorkingDirectory.__init__] Use of super on an old style class  [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:622:  [CompileWebKit.__init__] Use of super on an old style class  [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:1131:  [ArchiveTestResults.__init__] Use of super on an old style class  [pylint/E1002] [5]
Total errors found: 4 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jonathan Bedard]

Do we have an example of different logs? Seems like a good idea, I'd just like to see the difference.

[Aakash Jain]

(In reply to Jonathan Bedard from comment #3)
> Do we have an example of different logs? Seems like a good idea, I'd just like to see the difference.
https://ews-build.webkit.org/#/builders/13/builds/4477/steps/8/logs/stdio
vs
https://ews-build.webkit-uat.org/#/builders/7/builds/429/steps/9/logs/stdio

Similarly, from https://bugs.webkit.org/show_bug.cgi?id=197319:
https://ews-build.webkit.org/#/builders/9/builds/1071/steps/5/logs/stdio
vs
https://ews-build.webkit.org/#/builders/9/builds/3925/steps/6/logs/stdio

[WebKit Commit Bot]

Comment on attachment 373323 [details]
Patch

Clearing flags on attachment: 373323

Committed r247069: <https://trac.webkit.org/changeset/247069>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/52540408>