RESOLVED FIXED 197319
[ews-build] Do not print worker environment variables in each build step
https://bugs.webkit.org/show_bug.cgi?id=197319
Summary [ews-build] Do not print worker environment variables in each build step
Aakash Jain
Reported 2019-04-26 10:45:03 PDT
By default Buildbot prints worker's environment variables in each build step. This is unnecessary and makes the logs hard to read. We should disable printing environment variable in most of the build steps. example (from https://ews-build.webkit.org/#/builders/9/builds/1071/steps/5/logs/stdio): environment: Apple_PubSub_Socket_Render=/private/tmp/com.apple.launchd.aTwloZVLIM/Render HOME=/Users/buildbot LOGNAME=buildbot OLDPWD=/Users/buildbot PATH=/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin PWD=/Volumes/Data/worker/API-Tests-iOS-Simulator-EWS/build PYPI_MIRRORS=pypi.apple.com SHELL=/bin/bash SHLVL=1 SSH_AUTH_SOCK=/private/tmp/com.apple.launchd.D4SBJF1v2I/Listeners TMPDIR=/var/folders/vr/hgrp98wj6w797xrk_t22t3vh0000gn/T/ USER=buildbot VERSIONER_PYTHON_PREFER_32_BIT=no VERSIONER_PYTHON_VERSION=2.7 XPC_FLAGS=0x0 XPC_SERVICE_NAME=0 _=/usr/local/bin/twistd __CF_USER_TEXT_ENCODING=0x1F5:0x0:0x0 using PTY: False
Attachments
Patch (10.42 KB, patch)
2019-04-26 10:46 PDT, Aakash Jain
no flags
Patch (10.50 KB, patch)
2019-06-26 19:32 PDT, Aakash Jain
no flags
Aakash Jain
Comment 1 2019-04-26 10:46:52 PDT
EWS Watchlist
Comment 2 2019-04-26 10:50:17 PDT Comment hidden (obsolete)
Lucas Forschler
Comment 3 2019-04-26 11:58:29 PDT
looks good to me, except for the style errors... (not sure if that is avoidable)
Dean Johnson
Comment 4 2019-04-26 11:59:54 PDT
Comment on attachment 368335 [details] Patch Maybe it'd be worth setting logEnviron=False in a new base class that inherited from shell.ShellCommand? Such as: class MinimalLoggingShellCommand(shell.ShellCommand): logEnviron = False
Dean Johnson
Comment 5 2019-04-26 12:04:07 PDT
If you decide not to wrap shell.ShellCommand, I think the style errors can be avoided by moving the logEnviron=False to member vars of each class you want them used for. It's also a bit more clear since that's how other (static) step configurations are set.
Aakash Jain
Comment 6 2019-06-26 19:02:20 PDT
> class MinimalLoggingShellCommand(shell.ShellCommand): > logEnviron = False logEnviron can not be a class variable, it has to be passed an instance variable (passed in __init__). We noticed similar behavior with 'timeout' in https://github.com/buildbot/buildbot/issues/3887#issuecomment-356736827
Aakash Jain
Comment 7 2019-06-26 19:32:43 PDT
WebKit Commit Bot
Comment 8 2019-06-27 09:10:08 PDT
Comment on attachment 372993 [details] Patch Clearing flags on attachment: 372993 Committed r246882: <https://trac.webkit.org/changeset/246882>
WebKit Commit Bot
Comment 9 2019-06-27 09:10:09 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2019-06-27 09:11:17 PDT
Note You need to log in before you can comment on or make changes to this bug.