WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
199037
[WHLSL] Property resolver needs to recurse on newValueExpression for RMW operations
https://bugs.webkit.org/show_bug.cgi?id=199037
Summary
[WHLSL] Property resolver needs to recurse on newValueExpression for RMW oper...
Saam Barati
Reported
2019-06-19 15:54:31 PDT
``` float4x4 mul(float4x4 x, float4x4 y) { float4x4 result; result[0][0] = 0; result[0][0] += x[0][0] * y[0][0]; result[0][0] += x[0][1] * y[1][0]; result[0][0] += x[0][2] * y[2][0]; result[0][0] += x[0][3] * y[3][0]; result[0][1] = 0; result[0][1] += x[0][0] * y[0][1]; result[0][1] += x[0][1] * y[1][1]; result[0][1] += x[0][2] * y[2][1]; result[0][1] += x[0][3] * y[3][1]; result[0][2] = 0; result[0][2] += x[0][0] * y[0][2]; result[0][2] += x[0][1] * y[1][2]; result[0][2] += x[0][2] * y[2][2]; result[0][2] += x[0][3] * y[3][2]; result[0][3] = 0; result[0][3] += x[0][0] * y[0][3]; result[0][3] += x[0][1] * y[1][3]; result[0][3] += x[0][2] * y[2][3]; result[0][3] += x[0][3] * y[3][3]; result[1][0] = 0; result[1][0] += x[1][0] * y[0][0]; result[1][0] += x[1][1] * y[1][0]; result[1][0] += x[1][2] * y[2][0]; result[1][0] += x[1][3] * y[3][0]; result[1][1] = 0; result[1][1] += x[1][0] * y[0][1]; result[1][1] += x[1][1] * y[1][1]; result[1][1] += x[1][2] * y[2][1]; result[1][1] += x[1][3] * y[3][1]; result[1][2] = 0; result[1][2] += x[1][0] * y[0][2]; result[1][2] += x[1][1] * y[1][2]; result[1][2] += x[1][2] * y[2][2]; result[1][2] += x[1][3] * y[3][2]; result[1][3] = 0; result[1][3] += x[1][0] * y[0][3]; result[1][3] += x[1][1] * y[1][3]; result[1][3] += x[1][2] * y[2][3]; result[1][3] += x[1][3] * y[3][3]; result[2][0] = 0; result[2][0] += x[2][0] * y[0][0]; result[2][0] += x[2][1] * y[1][0]; result[2][0] += x[2][2] * y[2][0]; result[2][0] += x[2][3] * y[3][0]; result[2][1] = 0; result[2][1] += x[2][0] * y[0][1]; result[2][1] += x[2][1] * y[1][1]; result[2][1] += x[2][2] * y[2][1]; result[2][1] += x[2][3] * y[3][1]; result[2][2] = 0; result[2][2] += x[2][0] * y[0][2]; result[2][2] += x[2][1] * y[1][2]; result[2][2] += x[2][2] * y[2][2]; result[2][2] += x[2][3] * y[3][2]; result[2][3] = 0; result[2][3] += x[2][0] * y[0][3]; result[2][3] += x[2][1] * y[1][3]; result[2][3] += x[2][2] * y[2][3]; result[2][3] += x[2][3] * y[3][3]; result[3][0] = 0; result[3][0] += x[3][0] * y[0][0]; result[3][0] += x[3][1] * y[1][0]; result[3][0] += x[3][2] * y[2][0]; result[3][0] += x[3][3] * y[3][0]; result[3][1] = 0; result[3][1] += x[3][0] * y[0][1]; result[3][1] += x[3][1] * y[1][1]; result[3][1] += x[3][2] * y[2][1]; result[3][1] += x[3][3] * y[3][1]; result[3][2] = 0; result[3][2] += x[3][0] * y[0][2]; result[3][2] += x[3][1] * y[1][2]; result[3][2] += x[3][2] * y[2][2]; result[3][2] += x[3][3] * y[3][2]; result[3][3] = 0; result[3][3] += x[3][0] * y[0][3]; result[3][3] += x[3][1] * y[1][3]; result[3][3] += x[3][2] * y[2][3]; result[3][3] += x[3][3] * y[3][3]; return result; } ``` Makes High Zombie Finder fail
Attachments
patch
(20.10 KB, patch)
2019-06-20 12:23 PDT
,
Saam Barati
mmaxfield
: review+
Details
Formatted Diff
Diff
patch for landing
(19.54 KB, patch)
2019-06-20 12:38 PDT
,
Saam Barati
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Saam Barati
Comment 1
2019-06-20 10:55:37 PDT
Looking at this now
Saam Barati
Comment 2
2019-06-20 12:23:25 PDT
Created
attachment 372577
[details]
patch
Saam Barati
Comment 3
2019-06-20 12:38:52 PDT
Created
attachment 372578
[details]
patch for landing
WebKit Commit Bot
Comment 4
2019-06-20 13:10:12 PDT
Comment on
attachment 372578
[details]
patch for landing Clearing flags on attachment: 372578 Committed
r246649
: <
https://trac.webkit.org/changeset/246649
>
WebKit Commit Bot
Comment 5
2019-06-20 13:10:13 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6
2019-06-20 13:11:43 PDT
<
rdar://problem/51956598
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug