Bug 195864 – [WHLSL] read modify write expressions do no work as expected

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Myles C. Maxfield]

Something is amiss.

[Radar WebKit Bug Importer]

<rdar://problem/50746278>

[Robin Morisset]

Created attachment 369881 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 369881 [details]
Patch

Looks like this was just a stupid mistake I made. Stupid mistakes like this are why the test suite is so important.

[WebKit Commit Bot]

Comment on attachment 369881 [details]
Patch

Clearing flags on attachment: 369881

Committed r245312: <https://trac.webkit.org/changeset/245312>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Saam Barati]

This isn't actually fixed yet.

this doesn't parse:

```
int bar() {
    int foo;
    foo++;
}
```

[Saam Barati]

I think I had a crash yesterday when writing a loop like this:

```
for (uint I = 0; I < n; I++)
```

and had to instead write it like
```
for (uint I = 0; I < n; I = I + 1)
```

[Myles C. Maxfield]

Created attachment 372569 [details]
WIP

[Myles C. Maxfield]

Comment on attachment 372569 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=372569&action=review

> LayoutTests/webgpu/whlsl-read-modify-write.html:12
> +    buffer1 = buffer[0]++;

buffer[1] = buffer[0]++;

[Myles C. Maxfield]

Created attachment 372572 [details]
WIP

[Myles C. Maxfield]

Created attachment 372619 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 372619 [details]
Patch

Clearing flags on attachment: 372619

Committed r246681: <https://trac.webkit.org/changeset/246681>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Truitt Savell]

Looks like the new test webgpu/whlsl-read-modify-write.html
added in https://trac.webkit.org/changeset/246681/webkit

is missing results on WK2

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webgpu%2Fwhlsl-read-modify-write.html

[Myles C. Maxfield]

Committed r246696: <https://trac.webkit.org/changeset/246696>