Bug 198944 - Web Inspector: Elements: remove ellipses from "Break on" context menu item title
Summary: Web Inspector: Elements: remove ellipses from "Break on" context menu item title
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-17 17:15 PDT by Matt Baker
Modified: 2019-06-17 21:32 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.84 KB, patch)
2019-06-17 17:17 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2019-06-17 17:15:44 PDT
Per Apple's HI guidelines:

Menu Item Titles
A menu item title describes an action or attribute.

Use an ellipsis whenever choosing a menu item requires additional input from the user. The ellipsis character (…) means a dialog or separate window will open and prompt the user for additional information or to make a choice.

See: https://developer.apple.com/design/human-interface-guidelines/macos/menus/menu-anatomy/

Notes:
I don't believe that the above description of "additional input" or a "separate window" applies to submenus.
Comment 1 Matt Baker 2019-06-17 17:17:56 PDT
Created attachment 372298 [details]
Patch
Comment 2 Matt Baker 2019-06-17 17:21:21 PDT
(In reply to Matt Baker from comment #0)
> Per Apple's HI guidelines:
> 
> Menu Item Titles
> A menu item title describes an action or attribute.
> 
> Use an ellipsis whenever choosing a menu item requires additional input from
> the user. The ellipsis character (…) means a dialog or separate window will
> open and prompt the user for additional information or to make a choice.
> 
> See:
> https://developer.apple.com/design/human-interface-guidelines/macos/menus/
> menu-anatomy/
> 
> Notes:
> I don't believe that the above description of "additional input" or a
> "separate window" applies to submenus.

It just occurred to me that the arrow (">") glyph displayed in macOS menu item titles implies this, making the ellipses redundant.
Comment 3 Radar WebKit Bug Importer 2019-06-17 17:41:05 PDT
<rdar://problem/51829232>
Comment 4 Nikita Vasilyev 2019-06-17 18:06:55 PDT
Good find! I was wondering about these ellipses.
Comment 5 Devin Rousso 2019-06-17 21:01:37 PDT
Comment on attachment 372298 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2019-06-17 21:32:47 PDT
Comment on attachment 372298 [details]
Patch

Clearing flags on attachment: 372298

Committed r246532: <https://trac.webkit.org/changeset/246532>
Comment 7 WebKit Commit Bot 2019-06-17 21:32:49 PDT
All reviewed patches have been landed.  Closing bug.