Bug 198937 - Web Inspector: Elements: add/edit/copy/delete menus should have a "..." in the label
Summary: Web Inspector: Elements: add/edit/copy/delete menus should have a "..." in th...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-17 16:26 PDT by Devin Rousso
Modified: 2019-06-17 21:02 PDT (History)
3 users (show)

See Also:


Attachments
Patch (7.15 KB, patch)
2019-06-17 16:32 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (7.33 KB, patch)
2019-06-17 16:33 PDT, Devin Rousso
mattbaker: review-
drousso: commit-queue?
Details | Formatted Diff | Diff
[Image] After Patch is applied (310.39 KB, image/png)
2019-06-17 16:40 PDT, Devin Rousso
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-06-17 16:26:13 PDT
This matches the "Break on..." and makes it even clearer that you're supposed to click on one of the items in the submenu.
Comment 1 Devin Rousso 2019-06-17 16:32:26 PDT
Created attachment 372290 [details]
Patch
Comment 2 Devin Rousso 2019-06-17 16:33:32 PDT
Created attachment 372292 [details]
Patch
Comment 3 Devin Rousso 2019-06-17 16:40:39 PDT
Created attachment 372293 [details]
[Image] After Patch is applied
Comment 4 Matt Baker 2019-06-17 17:08:39 PDT
Comment on attachment 372292 [details]
Patch

This goes against Apple's HI Guidelines (which I clearly didn't check before adding the "Break on..." context menu item). Here is the relevant documentation:

[Copied from https://developer.apple.com/design/human-interface-guidelines/macos/menus/menu-anatomy/]

Menu Item Titles
A menu item title describes an action or attribute.

Use an ellipsis whenever choosing a menu item requires additional input from the user. The ellipsis character (…) means a dialog or separate window will open and prompt the user for additional information or to make a choice.
Comment 5 Matt Baker 2019-06-17 17:19:13 PDT
I've put up a patch to address the "Break on..." menu item title:

https://bugs.webkit.org/show_bug.cgi?id=198944