Bug 198790 - '\u' should throw an early SyntaxError exception, but instead evaluates to 'u'
Summary: '\u' should throw an early SyntaxError exception, but instead evaluates to 'u'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Trivial
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-12 08:37 PDT by Mathias Bynens
Modified: 2020-04-04 12:37 PDT (History)
13 users (show)

See Also:

Attachments
Patch (9.58 KB, patch)
2020-04-04 03:56 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Patch (10.59 KB, patch)
2020-04-04 08:13 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Patch (11.65 KB, patch)
2020-04-04 10:56 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathias Bynens 2019-06-12 08:37:25 PDT 
$ eshost -se '"\u"'
#### Chakra
SyntaxError: Expected hexadecimal digit

#### JavaScriptCore
u

#### SpiderMonkey
SyntaxError: malformed Unicode character escape sequence:

#### V8, V8 --harmony
SyntaxError: Invalid Unicode escape sequence

#### xs
SyntaxError: invalid escape sequence
Comment 1 Alexey Shvayka 2020-04-04 03:56:16 PDT 
Created attachment 395444 [details]
Patch
Comment 2 Alexey Shvayka 2020-04-04 08:13:41 PDT 
Created attachment 395448 [details]
Patch

Adjust old Mozilla test.
Comment 3 Mark Lam 2020-04-04 09:35:25 PDT 
Comment on attachment 395448 [details]
Patch

r- for now because a JSC test is still failing.  Please check the other bots as well to make sure their failures are not related.
Comment 4 Alexey Shvayka 2020-04-04 10:56:55 PDT 
Created attachment 395458 [details]
Patch

Array/15.4.5.1-1.js failures turned out to be related after all, adjust it.
Comment 5 Yusuke Suzuki 2020-04-04 12:33:04 PDT 
Comment on attachment 395458 [details]
Patch

r=me
Comment 6 EWS 2020-04-04 12:36:37 PDT 
Committed r259536: <https://trac.webkit.org/changeset/259536>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 395458 [details].
Comment 7 Radar WebKit Bug Importer 2020-04-04 12:37:12 PDT 
<rdar://problem/61301054>