Bug 144377 – [ES6] Implement Unicode code point escapes

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Darin Adler]

[ES6] Implement Unicode code point escapes

[Darin Adler]

Created attachment 251928 [details]
Patch

[Darin Adler]

Created attachment 251932 [details]
Patch

[Antti Koivisto]

Comment on attachment 251932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251932&action=review

> Source/JavaScriptCore/parser/Lexer.cpp:624
> +    enum SpecialValueType { Incomplete, Invalid };
> +    ParsedUnicodeEscapeValue(SpecialValueType type)
> +        : m_value(type == Incomplete ? -2 : -1)
> +    {
> +    }

Why not enum SpecialValue { Incomplete = -2, Invalid = -1} and use them directly?

> Source/JavaScriptCore/parser/Lexer.cpp:709
> +static ALWAYS_INLINE bool isLatin1(UChar32 c)
> +{
> +    return !(c & ~0xFF);
> +}

No existing helper for this?

[Darin Adler]

Comment on attachment 251932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251932&action=review

>> Source/JavaScriptCore/parser/Lexer.cpp:624
>> +    }
> 
> Why not enum SpecialValue { Incomplete = -2, Invalid = -1} and use them directly?

I will do that.

>> Source/JavaScriptCore/parser/Lexer.cpp:709
>> +}
> 
> No existing helper for this?

There’s not anything I could find. I was looking for a Latin-1 equivalent to the functions in ASCIICType.h and did not find one.

[Darin Adler]

Committed r183552: <http://trac.webkit.org/changeset/183552>