Bug 198758 - [Win] Layout test http/tests/security/contentSecurityPolicy/navigate-self-to-blob.html is timing out
Summary: [Win] Layout test http/tests/security/contentSecurityPolicy/navigate-self-to-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-11 10:20 PDT by Ryan Haddad
Modified: 2019-06-12 09:36 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.33 KB, patch)
2019-06-11 10:44 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2019-06-11 10:20:22 PDT
Layout test http/tests/security/contentSecurityPolicy/navigate-self-to-blob.html is consistently timing out on Win7 and Win10 bots with no output

https://build.webkit.org/builders/Apple%20Win%2010%20Release%20(Tests)/builds/2531

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2FcontentSecurityPolicy%2Fnavigate-self-to-blob.html
Comment 1 Ryan Haddad 2019-06-11 10:22:28 PDT
This test was just added with https://trac.webkit.org/changeset/246287
Comment 2 Daniel Bates 2019-06-11 10:44:36 PDT
Created attachment 371853 [details]
Patch
Comment 3 Daniel Bates 2019-06-11 10:45:06 PDT
Committed r246324: <https://trac.webkit.org/changeset/246324>
Comment 4 Radar WebKit Bug Importer 2019-06-11 10:46:15 PDT
<rdar://problem/51630066>
Comment 5 Alexey Proskuryakov 2019-06-11 12:20:29 PDT
Comment on attachment 371853 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371853&action=review

> LayoutTests/platform/win/TestExpectations:2282
> +# FIXME: Navigating to blob URLs timeout

Which bugs tracks this?

It is not really meaningful to claim that this bug here is resolved as fixed when you only moved an existing Skip line - that fixes nothing.
Comment 6 Daniel Bates 2019-06-11 12:34:52 PDT
(In reply to Alexey Proskuryakov from comment #5)
> Comment on attachment 371853 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371853&action=review
> 
> > LayoutTests/platform/win/TestExpectations:2282
> > +# FIXME: Navigating to blob URLs timeout
> 
> Which bugs tracks this?
> 
> It is not really meaningful to claim that this bug here is resolved as fixed
> when you only moved an existing Skip line - that fixes nothing.

Reopen and retitle this bug (since analogous test in 2015 was skipped) or file a new bug. My opinion, the latter.
Comment 7 Alexey Proskuryakov 2019-06-12 03:39:02 PDT
Dan, cleaning up after yourself is something that you are supposed to do.
Comment 8 Daniel Bates 2019-06-12 06:39:59 PDT
(In reply to Alexey Proskuryakov from comment #7)
> Dan, cleaning up after yourself is something that you are supposed to do.

I don't understand. What is there to clean up?
Comment 9 Daniel Bates 2019-06-12 06:50:55 PDT
If you're asking me to file a new bug, I can do that. If you, you could have been a team player and done this.