Bug 198687 – Integrate dark mode support for iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Timothy Hatcher]

Put iOS dark mode support in the open source.

[Radar WebKit Bug Importer]

<rdar://problem/51545643>

[Timothy Hatcher]

Created attachment 371702 [details]
Patch

[Timothy Hatcher]

Created attachment 371704 [details]
Patch

[EWS Watchlist]

Attachment 371704 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/LocalCurrentTraitCollection.mm:30:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Timothy Hatcher]

Created attachment 371705 [details]
Patch

[Tim Horton]

Comment on attachment 371705 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371705&action=review

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:119
> +ENABLE_DARK_MODE_CSS_iphonesimulator = ENABLE_DARK_MODE_CSS;

Probably iosmac too?

[Timothy Hatcher]

Created attachment 371709 [details]
Patch

[Timothy Hatcher]

Created attachment 371712 [details]
Patch

[Timothy Hatcher]

Created attachment 371715 [details]
Patch

[Tim Horton]

Comment on attachment 371715 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371715&action=review

> Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm:133
> +    styleConfiguration.appearanceName = coreContext.useDarkAppearance() ? @"UIAppearanceDark" : @"UIAppearanceLight";

No constants for these?

[Timothy Hatcher]

(In reply to Tim Horton from comment #10)
> Comment on attachment 371715 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371715&action=review
> 
> > Source/WebCore/platform/graphics/cocoa/FontCascadeCocoa.mm:133
> > +    styleConfiguration.appearanceName = coreContext.useDarkAppearance() ? @"UIAppearanceDark" : @"UIAppearanceLight";
> 
> No constants for these?

Sadly not.

[WebKit Commit Bot]

Comment on attachment 371715 [details]
Patch

Clearing flags on attachment: 371715

Committed r246270: <https://trac.webkit.org/changeset/246270>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Frédéric Wang (:fredw)]

Comment on attachment 371715 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371715&action=review

@Timothy: I get various build failure for missing API when building with the latest XCode 11 beta 3 (FontCascadeCocoa.mm, LocalCurrentTraitCollection.mm and RenderThemeIOS.mm ). Is it something expected?

> Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:167
> ++ (UIColor *)tableCellDefaultSelectionTintColor;

I'm not familiar with Objective C but this is causing a build failure for me with XCode 11 beta 3, that I can workaround by moving this above the NS_ASSUME_NONNULL_END statement.

[Frédéric Wang (:fredw)]

(In reply to Frédéric Wang (:fredw) from comment #14)
> Comment on attachment 371715 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371715&action=review
> 
> @Timothy: I get various build failure for missing API when building with the
> latest XCode 11 beta 3 (FontCascadeCocoa.mm, LocalCurrentTraitCollection.mm
> and RenderThemeIOS.mm ).

(in OS_DARK_MODE_SUPPORT sections)

[Timothy Hatcher]

Comment on attachment 371715 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=371715&action=review

>> Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:167
>> ++ (UIColor *)tableCellDefaultSelectionTintColor;
> 
> I'm not familiar with Objective C but this is causing a build failure for me with XCode 11 beta 3, that I can workaround by moving this above the NS_ASSUME_NONNULL_END statement.

Moving to NS_ASSUME_NONNULL_END section or adding a new section of START and END likely is the right fix. File a new bug with the build errors and we can take a look.

[Timothy Hatcher]

(In reply to Timothy Hatcher from comment #16)
> Comment on attachment 371715 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=371715&action=review
> 
> >> Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:167
> >> ++ (UIColor *)tableCellDefaultSelectionTintColor;
> > 
> > I'm not familiar with Objective C but this is causing a build failure for me with XCode 11 beta 3, that I can workaround by moving this above the NS_ASSUME_NONNULL_END statement.
> 
> Moving to NS_ASSUME_NONNULL_END section or adding a new section of START and
> END likely is the right fix. File a new bug with the build errors and we can
> take a look.

Bug 199481 tracks making WebKit build with the public SDK.

[Frédéric Wang (:fredw)]

(In reply to Timothy Hatcher from comment #17)
> (In reply to Timothy Hatcher from comment #16)
> > Comment on attachment 371715 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=371715&action=review
> > 
> > >> Source/WebCore/PAL/pal/spi/ios/UIKitSPI.h:167
> > >> ++ (UIColor *)tableCellDefaultSelectionTintColor;
> > > 
> > > I'm not familiar with Objective C but this is causing a build failure for me with XCode 11 beta 3, that I can workaround by moving this above the NS_ASSUME_NONNULL_END statement.
> > 
> > Moving to NS_ASSUME_NONNULL_END section or adding a new section of START and
> > END likely is the right fix. File a new bug with the build errors and we can
> > take a look.
> 
> Bug 199481 tracks making WebKit build with the public SDK.

Thanks!