RESOLVED FIXED Bug 199481
[iOS 13] Enable WebKit build 
https://bugs.webkit.org/show_bug.cgi?id=199481
Summary [iOS 13] Enable WebKit build
Jonathan Bedard
Reported 2019-07-03 16:45:44 PDT
WebKit should build with the public iOS 13 SDK.
Attachments
patch-1 (21.83 KB, patch)
2019-07-09 13:38 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
patch-2 (21.87 KB, patch)
2019-07-09 13:51 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
patch-3 (22.10 KB, patch)
2019-07-09 15:58 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
patch-4 (22.12 KB, patch)
2019-07-09 16:44 PDT, Jonathan Bedard 		thorton: review+
DetailsFormatted DiffDiff
patch-5 (21.74 KB, patch)
2019-07-10 17:08 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.95 KB, patch)
2019-09-17 16:02 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-07-03 16:46:10 PDT
<rdar://problem/52619048>
Jonathan Bedard
Comment 2 2019-07-09 13:38:41 PDT
Created attachment 373752 [details] patch-1
EWS Watchlist
Comment 3 2019-07-09 13:41:06 PDT
Attachment 373752 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSProgressSPI.h:30: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jonathan Bedard
Comment 4 2019-07-09 13:51:31 PDT
Created attachment 373756 [details] patch-2
EWS Watchlist
Comment 5 2019-07-09 14:05:06 PDT
Attachment 373756 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSProgressSPI.h:30: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jonathan Bedard
Comment 6 2019-07-09 15:58:47 PDT
Created attachment 373787 [details] patch-3
EWS Watchlist
Comment 7 2019-07-09 16:02:07 PDT
Attachment 373787 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSProgressSPI.h:30: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jonathan Bedard
Comment 8 2019-07-09 16:44:33 PDT
Created attachment 373791 [details] patch-4
EWS Watchlist
Comment 9 2019-07-09 16:46:00 PDT
Attachment 373791 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSProgressSPI.h:30: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 10 2019-07-10 16:01:53 PDT
This bug needs a better title.
Jonathan Bedard
Comment 11 2019-07-10 17:08:19 PDT
Created attachment 373879 [details] patch-5
EWS Watchlist
Comment 12 2019-07-10 17:23:04 PDT
Attachment 373879 [details] did not pass style-queue: ERROR: Source/WebCore/PAL/pal/spi/cocoa/NSProgressSPI.h:30: Misplaced OS version check. Please use a named macro in wtf/Platform.h, wtf/FeatureDefines.h, or an appropriate internal file. [build/version_check] [5] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 13 2019-07-11 10:18:05 PDT
Comment on attachment 373879 [details] patch-5 Clearing flags on attachment: 373879 Committed r247355: <https://trac.webkit.org/changeset/247355>
WebKit Commit Bot
Comment 14 2019-07-11 10:18:06 PDT
All reviewed patches have been landed. Closing bug.
Jonathan Bedard
Comment 15 2019-09-17 16:02:30 PDT
Reopening to attach new patch.
Jonathan Bedard
Comment 16 2019-09-17 16:02:31 PDT
Created attachment 379002 [details] Patch
WebKit Commit Bot
Comment 17 2019-09-17 19:48:16 PDT
Comment on attachment 379002 [details] Patch Clearing flags on attachment: 379002 Committed r250020: <https://trac.webkit.org/changeset/250020>
WebKit Commit Bot
Comment 18 2019-09-17 19:48:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.