WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 19863
WebKitCSSTransformValue needs DOM interface
https://bugs.webkit.org/show_bug.cgi?id=19863
Summary
WebKitCSSTransformValue needs DOM interface
Dean Jackson
Reported
2008-07-02 18:40:58 PDT
The WebKitCSSTransformValue needs a (simple) DOM interface
Attachments
Adds IDL and updates projects
(13.20 KB, patch)
2008-07-02 18:41 PDT
,
Dean Jackson
hyatt
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dean Jackson
Comment 1
2008-07-02 18:41:41 PDT
Created
attachment 22056
[details]
Adds IDL and updates projects
Eric Seidel (no email)
Comment 2
2008-07-04 11:19:00 PDT
Comment on
attachment 22056
[details]
Adds IDL and updates projects Why the WebKit prefix on the JS class name? I've never seen us do that before...
Dave Hyatt
Comment 3
2008-07-04 12:41:03 PDT
Because we expect that it will change significantly. Doing will avoid name clashes and let us make changes that won't break backwards compatibility with the phone. We should have done this with <canvas>... it would have saved us a lot of headaches.
Simon Fraser (smfr)
Comment 4
2008-07-07 20:25:03 PDT
+ // OperationTypes + const unsigned short CSS_MATRIX = 1; + const unsigned short CSS_ROTATE = 3; + const unsigned short CSS_TRANSLATE = 5; + const unsigned short CSS_SCALE = 7; + const unsigned short CSS_SKEWX = 9; + const unsigned short CSS_SKEWY = 10; + const unsigned short CSS_TRANSLATEX = 16; + const unsigned short CSS_TRANSLATEY = 17; + const unsigned short CSS_SCALEX = 19; + const unsigned short CSS_SCALEY = 20; I think a comment is required here to warn people from making the values contiguous.
Dave Hyatt
Comment 5
2008-07-08 11:14:42 PDT
Comment on
attachment 22056
[details]
Adds IDL and updates projects r=me
Dean Jackson
Comment 6
2008-07-08 15:09:56 PDT
I'll explain why there are gaps in the enum.
Dean Jackson
Comment 7
2008-07-09 18:03:55 PDT
Done in 35084
http://trac.webkit.org/changeset/35084
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug