Bug 19861 - CSSTransformList should be WebKitCSSTransformList
Summary: CSSTransformList should be WebKitCSSTransformList
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 19028 19863
  Show dependency treegraph
 
Reported: 2008-07-02 16:18 PDT by Dean Jackson
Modified: 2008-08-04 11:18 PDT (History)
2 users (show)

See Also:


Attachments
Patch to rename CSSTransformValue and change inheritance (39.58 KB, patch)
2008-07-02 16:19 PDT, Dean Jackson
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2008-07-02 16:18:11 PDT
The CSSTransformList class should be named WebKitCSSTransformList (the same as the DOM interface to come in a subsequent patch). It should also inherit from CSSValueList rather than CSSValue.
Comment 1 Dean Jackson 2008-07-02 16:19:25 PDT
Created attachment 22053 [details]
Patch to rename CSSTransformValue and change inheritance

This should also change the build for all platforms
Comment 2 Dean Jackson 2008-07-02 16:50:36 PDT
oops - line 36 of WebKitCSSTransformValue.cpp should be
CSSValueList(false)

Comment 3 Dean Jackson 2008-07-02 18:58:04 PDT
forget the oops - the patch is correct. The transform list should be space separated, not comma.

Comment 4 Dave Hyatt 2008-07-08 11:14:08 PDT
Comment on attachment 22053 [details]
Patch to rename CSSTransformValue and change inheritance

r=me
Comment 5 Dean Jackson 2008-07-09 17:28:16 PDT
Done in 35081
http://trac.webkit.org/changeset/35081