Bug 198463 - Remove include directives unused since r245186
Summary: Remove include directives unused since r245186
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konstantin Tokarev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-06-01 15:22 PDT by Konstantin Tokarev
Modified: 2019-06-02 20:23 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.20 KB, patch)
2019-06-01 15:23 PDT, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Patch (1.14 KB, patch)
2019-06-01 15:36 PDT, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews211 for win-future (14.25 MB, application/zip)
2019-06-01 18:23 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2019-06-01 15:22:25 PDT 
Remove include directives in NetworkCacheBlobStorage.cpp unused since r245186
Comment 1 Konstantin Tokarev 2019-06-01 15:23:57 PDT 
Created attachment 371123 [details]
Patch
Comment 2 Konstantin Tokarev 2019-06-01 15:36:22 PDT 
Created attachment 371125 [details]
Patch
Comment 3 Konstantin Tokarev 2019-06-01 15:57:18 PDT 
It seems wrong that while OS(WINDOWS) conditional compilation was removed from NetworkCacheBlobStorage.cpp, common code is using POSIX functions stat() and unlink(). Apparently they are used on Windows without including their headers
Comment 4 EWS Watchlist 2019-06-01 18:23:54 PDT 
Comment on attachment 371125 [details]
Patch

Attachment 371125 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12351821

New failing tests:
storage/indexeddb/modern/get-keyrange.html
Comment 5 EWS Watchlist 2019-06-01 18:23:57 PDT 
Created attachment 371136 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 6 WebKit Commit Bot 2019-06-01 20:02:07 PDT 
Comment on attachment 371125 [details]
Patch

Clearing flags on attachment: 371125

Committed r246020: <https://trac.webkit.org/changeset/246020>
Comment 7 WebKit Commit Bot 2019-06-01 20:02:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-06-01 20:03:19 PDT 
<rdar://problem/51335245>
Comment 9 Fujii Hironori 2019-06-02 20:23:16 PDT 
(In reply to Konstantin Tokarev from comment #3)
> It seems wrong that while OS(WINDOWS) conditional compilation was removed
> from NetworkCacheBlobStorage.cpp, common code is using POSIX functions
> stat() and unlink(). Apparently they are used on Windows without including
> their headers

Filed in Bug 198473.