Bug 198473 - [Win] Implement NetworkCacheBlobStorage.cpp without stat and unlink
Summary: [Win] Implement NetworkCacheBlobStorage.cpp without stat and unlink
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-02 20:22 PDT by Fujii Hironori
Modified: 2019-06-02 20:40 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-06-02 20:22:46 PDT
[Win] Implement NetworkCacheBlobStorage.cpp without stat and unlink

unlink is deprecated
https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/unlink?view=vs-2019

_unlink
https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/unlink-wunlink?view=vs-2019

_stat、_stat32、_stat64、_stati64、_stat32i64、_stat64i32、_wstat、_wstat32、_wstat64、_wstati64、_wstat32i64、_wstat64i32 | Microsoft Docs
https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/stat-functions?view=vs-2019
Comment 1 Konstantin Tokarev 2019-06-02 20:34:19 PDT
Proper direction would be to convert as much as possible of NetworkCache code to be cross-platform by using our FileSystem abstractions, e.g. FileSystem::deleteFile instead of unlink

In future we may want to use std::filesystem to implement some of operations
Comment 2 Konstantin Tokarev 2019-06-02 20:40:36 PDT
And where are substantial differences which require code to be #ifdef'ed, it would be better to avoid increasing of #ifdef's and instead separate parts of code to respective *POSIX.cpp and *Win.cpp files