Bug 198139 - Fix scrolling tree state for more obscure combinations of positioning and paint order
Summary: Fix scrolling tree state for more obscure combinations of positioning and pai...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-22 14:45 PDT by Simon Fraser (smfr)
Modified: 2019-05-23 11:10 PDT (History)
4 users (show)

See Also:


Attachments
Patch (22.27 KB, patch)
2019-05-22 14:50 PDT, Simon Fraser (smfr)
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-05-22 14:45:10 PDT
Fix scrolling tree state for more obscure combinations of positioning and paint order
Comment 1 Simon Fraser (smfr) 2019-05-22 14:50:19 PDT
Created attachment 370447 [details]
Patch
Comment 2 Antti Koivisto 2019-05-22 15:08:35 PDT
Comment on attachment 370447 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370447&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1800
> +// This is a simplified version of containing block walking that only handles absolute position.
> +static AncestorTraversal traverseAncestorLayers(const RenderLayer& layer, const WTF::Function<AncestorTraversal(const RenderLayer&, bool inContainingBlockChain, bool isPaintOrderAncestor)>& ancestorFunc)

Using template argument instead of WTF::Function would avoid unnecessary virtual function calls.
Comment 3 Simon Fraser (smfr) 2019-05-22 15:58:43 PDT
https://trac.webkit.org/r245656
Comment 4 Radar WebKit Bug Importer 2019-05-22 15:59:25 PDT
<rdar://problem/51046303>