Bug 198105 – run-webkit-tests: Remove feature detection support

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Fujii Hironori]

run-webkit-tests: Remove feature detection support

Feature detection support has been added to Windows port's DRT
and old run-webkit-tests in Bug 35610. It has been added for NRWT
in Bug 41842. But, it doesn't work for Windows port's DRT because
feature names mismatch. Since USE(ACCELERATED_COMPOSITING) flag
has been removed in Bug 127833, it is not needed anymore.

[Fujii Hironori]

Created attachment 370391 [details]
Patch

[Jonathan Bedard]

Comment on attachment 370391 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370391&action=review

> LayoutTests/ChangeLog:10
> +        Skip all compositing, animations/3d and transforms/3d temporarily.

If this is actually temporary, we should put FIXMEs in expectations, otherwise we'll lose track of why they were skipped.

[Fujii Hironori]

Comment on attachment 370391 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370391&action=review

>> LayoutTests/ChangeLog:10
>> +        Skip all compositing, animations/3d and transforms/3d temporarily.
> 
> If this is actually temporary, we should put FIXMEs in expectations, otherwise we'll lose track of why they were skipped.

In WinCairo TestExpectations, I added the Skip in "TEMPORARY SKIPS" section. I think no additional comment is needed.
https://github.com/WebKit/webkit/blob/d3d6b28920d2f449f918a3c2da9c48d15bb59002/LayoutTests/platform/wincairo/TestExpectations#L1502

In AppleWin TestExpectations, I'm going to move the Skip to "UNREVIEWED failures" section.
https://github.com/WebKit/webkit/blob/d3d6b28920d2f449f918a3c2da9c48d15bb59002/LayoutTests/platform/win/TestExpectations#L2601

[Fujii Hironori]

Created attachment 370477 [details]
Patch

* Addressed review feedbacks.

[Jonathan Bedard]

Comment on attachment 370477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=370477&action=review

> Tools/ChangeLog:8
> +        Feature detection support has been added to Windows port's DRT and

Should be: 'Feature detection support was added to DRT for Windows and...'

> Tools/ChangeLog:9
> +        old run-webkit-tests in Bug 35610. It has been added for NRWT in

Likewise: 'It was added for NRWT in...'

> Tools/ChangeLog:10
> +        Bug 41842. But, it doesn't work for Windows port's DRT because

'But it doesn't work for DRT for Windows because of...'

[Fujii Hironori]

Created attachment 370544 [details]
Patch for landing

[Fujii Hironori]

Created attachment 370545 [details]
Patch for landing

[Fujii Hironori]

webkitpy EWS failure is irrelevant for the patch. BuildBot is also failing.
https://build.webkit.org/builders/Apple%20Mojave%20Release%20WK2%20%28Tests%29/builds/4289

[Fujii Hironori]

Committed r245733: <https://trac.webkit.org/changeset/245733>

[Radar WebKit Bug Importer]

<rdar://problem/51092639>