Bug 127833 - Remove the ACCELERATED_COMPOSITING flag
Summary: Remove the ACCELERATED_COMPOSITING flag
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrei Bucur
Keywords: AdobeTracked
Depends on:
Reported: 2014-01-29 00:27 PST by Andrei Bucur
Modified: 2014-01-30 02:18 PST (History)
35 users (show)

See Also:

Patch (434.85 KB, patch)
2014-01-29 06:26 PST, Andrei Bucur
no flags Details | Formatted Diff | Diff
Patch for landing (434.65 KB, patch)
2014-01-30 01:12 PST, Andrei Bucur
no flags Details | Formatted Diff | Diff
Patch for landing with Cairo fix (434.83 KB, patch)
2014-01-30 01:39 PST, Andrei Bucur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Bucur 2014-01-29 00:27:14 PST
Accelerated compositing is enabled by default on the main platforms. Also, other major WebKit ports plan to enable it sometimes in the near future. Given this information, remove the flag and make AC mandatory.
Comment 1 Andrei Bucur 2014-01-29 06:26:32 PST
Created attachment 222569 [details]
Comment 2 WebKit Commit Bot 2014-01-29 06:28:46 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Andrei Bucur 2014-01-29 06:35:24 PST
I'll need some help from the port maintainers to take a look over it (and make sure this is safe to land). The patch doesn't change any build system configurations or scripts. Basically, if the flag is set, it's never used by the code. This gives freedom to the port maintainers to adjust their infrastructure as they see fit.
Comment 4 Alex Christensen 2014-01-29 10:59:13 PST
I'd like https://bugs.webkit.org/show_bug.cgi?id=127843 landed before this patch.  https://bugs.webkit.org/show_bug.cgi?id=127844 won't be necessary any more after this patch, though.  I'm in favor of this change, and I don't want WinCairo to break or hold back this development.
Comment 5 Andrei Bucur 2014-01-30 01:12:23 PST
Created attachment 222643 [details]
Patch for landing
Comment 6 Andrei Bucur 2014-01-30 01:39:33 PST
Created attachment 222644 [details]
Patch for landing with Cairo fix
Comment 7 WebKit Commit Bot 2014-01-30 02:18:00 PST
Comment on attachment 222644 [details]
Patch for landing with Cairo fix

Clearing flags on attachment: 222644

Committed r163079: <http://trac.webkit.org/changeset/163079>
Comment 8 WebKit Commit Bot 2014-01-30 02:18:06 PST
All reviewed patches have been landed.  Closing bug.