Bug 198000 - [ews-app] Status bubble should not turn orange when any build step has warnings
Summary: [ews-app] Status bubble should not turn orange when any build step has warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-17 14:14 PDT by Aakash Jain
Modified: 2019-06-20 14:20 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.26 KB, patch)
2019-05-17 14:15 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-05-17 14:14:12 PDT
https://bugs.webkit.org/show_bug.cgi?id=197812 added support for status-bubble turning orange when in-progress build has any failed step. However, it also turns orange in case of steps with a warning. warning is common for compile-webkit step. Status bubbles should not turn orange in case of build step with warnings.
Comment 1 Aakash Jain 2019-05-17 14:15:37 PDT
Created attachment 370150 [details]
Patch
Comment 2 WebKit Commit Bot 2019-05-17 16:41:53 PDT
Comment on attachment 370150 [details]
Patch

Clearing flags on attachment: 370150

Committed r245487: <https://trac.webkit.org/changeset/245487>
Comment 3 WebKit Commit Bot 2019-05-17 16:41:54 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-05-17 16:42:18 PDT
<rdar://problem/50910655>