Bug 197812 - [ews-app] Status bubble should turn orange when any build step fails
Summary: [ews-app] Status bubble should turn orange when any build step fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-05-10 21:00 PDT by Aakash Jain
Modified: 2019-05-17 14:14 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.23 KB, patch)
2019-05-10 21:04 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-05-10 21:00:45 PDT 
[ews-app] Status bubble should turn orange when any build step fails. This would be similar to old EWS behavior. This should make engineers pay more attention to the EWS when one of step in build has failed, but the build hasn't finished (EWS might be retrying to confirm if the issue is pre-existing).

It is especially important to look into EWS when there is some failure. EWS might take additional time between finding the first failure and confirming the failure (since it need to retry the patch, and do clean build etc.). During that time status-bubbles should be orange so that they are more noticeable.
Comment 1 Aakash Jain 2019-05-10 21:04:10 PDT 
Created attachment 369636 [details]
Patch
Comment 2 WebKit Commit Bot 2019-05-14 09:18:29 PDT 
Comment on attachment 369636 [details]
Patch

Clearing flags on attachment: 369636

Committed r245282: <https://trac.webkit.org/changeset/245282>
Comment 3 WebKit Commit Bot 2019-05-14 09:18:31 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-05-14 09:19:51 PDT 
<rdar://problem/50769123>