197829 – Web Inspector: Formatter: pretty-print CSS using a Worker

RESOLVED FIXED 197829

Web Inspector: Formatter: pretty-print CSS using a Worker

https://bugs.webkit.org/show_bug.cgi?id=197829

Summary Web Inspector: Formatter: pretty-print CSS using a Worker

Devin Rousso

Reported 2019-05-12 22:46:44 PDT

For extremely large CSS files, it can take a very long time for us to pretty-print it using CodeMirror. Rather than pretty-print using the main thread (e.g. CodeMirror), we should do the same as JavaScript and pretty-print off the main thread (e.g. a Worker).

Attachments
Patch (12.02 KB, patch) 2019-05-12 22:53 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews213 for win-future (13.45 MB, application/zip) 2019-05-13 08:57 PDT, EWS Watchlist	no flags	Details
Patch (32.45 KB, patch) 2019-05-15 03:56 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2019-05-12 22:49:59 PDT

<rdar://problem/36891532>

Devin Rousso

Comment 2 2019-05-12 22:53:03 PDT

Created attachment 369695 [details] Patch This is probably missing some edge cases, and should have some tests, but it's a start :)

EWS Watchlist

Comment 3 2019-05-12 22:55:14 PDT Comment hidden (obsolete)

Attachment 369695 [details] did not pass style-queue: ERROR: Source/WebInspectorUI/UserInterface/Workers/Formatter/CSSFormatter.js:64: Line contains single-quote character. [js/syntax] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 4 2019-05-13 08:57:53 PDT Comment hidden (obsolete)

Comment on attachment 369695 [details] Patch Attachment 369695 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12176877 New failing tests: js/dom/custom-constructors.html

EWS Watchlist

Comment 5 2019-05-13 08:57:55 PDT Comment hidden (obsolete)

Created attachment 369736 [details] Archive of layout-test-results from ews213 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Devin Rousso

Comment 6 2019-05-15 03:56:58 PDT

Created attachment 369944 [details] Patch

EWS Watchlist

Comment 7 2019-05-15 03:58:53 PDT Comment hidden (obsolete)

Attachment 369944 [details] did not pass style-queue: ERROR: Source/WebInspectorUI/UserInterface/Workers/Formatter/CSSFormatter.js:64: Line contains single-quote character. [js/syntax] [5] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 8 2019-06-06 16:35:18 PDT

Comment on attachment 369944 [details] Patch Clearing flags on attachment: 369944 Committed r246178: <https://trac.webkit.org/changeset/246178>

WebKit Commit Bot

Comment 9 2019-06-06 16:35:19 PDT

All reviewed patches have been landed. Closing bug.

Joseph Pecoraro

Comment 10 2019-06-06 16:43:43 PDT

Comment on attachment 369944 [details] Patch Nice!

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware All

OS All

Product WebKit

Component Web Inspector

Assignee

Devin Rousso

Reported

2019-05-12 22:46 PDT

Modified

2019-06-12 14:34 PDT History

CC List

7 users Show

URL

Keywords InRadar

Depends on

Blocks

198806 198807

Dependencies

tree graph