RESOLVED FIXED 197829
Web Inspector: Formatter: pretty-print CSS using a Worker
https://bugs.webkit.org/show_bug.cgi?id=197829
Summary Web Inspector: Formatter: pretty-print CSS using a Worker
Devin Rousso
Reported 2019-05-12 22:46:44 PDT
For extremely large CSS files, it can take a very long time for us to pretty-print it using CodeMirror. Rather than pretty-print using the main thread (e.g. CodeMirror), we should do the same as JavaScript and pretty-print off the main thread (e.g. a Worker).
Attachments
Patch (12.02 KB, patch)
2019-05-12 22:53 PDT, Devin Rousso
no flags
Archive of layout-test-results from ews213 for win-future (13.45 MB, application/zip)
2019-05-13 08:57 PDT, EWS Watchlist
no flags
Patch (32.45 KB, patch)
2019-05-15 03:56 PDT, Devin Rousso
no flags
Devin Rousso
Comment 1 2019-05-12 22:49:59 PDT
Devin Rousso
Comment 2 2019-05-12 22:53:03 PDT
Created attachment 369695 [details] Patch This is probably missing some edge cases, and should have some tests, but it's a start :)
EWS Watchlist
Comment 3 2019-05-12 22:55:14 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 4 2019-05-13 08:57:53 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 5 2019-05-13 08:57:55 PDT Comment hidden (obsolete)
Devin Rousso
Comment 6 2019-05-15 03:56:58 PDT
EWS Watchlist
Comment 7 2019-05-15 03:58:53 PDT Comment hidden (obsolete)
WebKit Commit Bot
Comment 8 2019-06-06 16:35:18 PDT
Comment on attachment 369944 [details] Patch Clearing flags on attachment: 369944 Committed r246178: <https://trac.webkit.org/changeset/246178>
WebKit Commit Bot
Comment 9 2019-06-06 16:35:19 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 10 2019-06-06 16:43:43 PDT
Comment on attachment 369944 [details] Patch Nice!
Note You need to log in before you can comment on or make changes to this bug.